Skip to content

gh-75261: Propogate use_rawinput to recursive pdb (debug command) #2947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
segevfiner wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-75261: Propogate use_rawinput to recursive pdb (debug command) #2947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
454e372
bpo-31078: Propogate use_rawinput to recursive pdb (debug command)
segevfiner Jul 29, 2017
abdfb28
Add NEWS.d entry
segevfiner Mar 1, 2019
8b41a79
Merge remote-tracking branch 'upstream/main' into bpo-31078-recursive…
segevfiner Feb 21, 2022
b5769bf
Merge branch 'main' into bpo-31078-recursive-pdb-rawinput
segevfiner Sep 26, 2022
0d2b9f2
Merge branch 'main' into bpo-31078-recursive-pdb-rawinput
arhadthedev Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,6 +1182,7 @@ def do_debug(self, arg):
globals = self.curframe.f_globals
locals = self.curframe_locals
p = Pdb(self.completekey, self.stdin, self.stdout)
p.use_rawinput = self.use_rawinput
Copy link
Copy Markdown
Contributor

@blueyed blueyed Mar 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could have a comment that this is required because "stdout" is passed.

As for a test, you could inspect frames (similar to pdbpp/pdbpp#169), but not sure if that is really useful / worth it.

(I just came across this again, after having backported it to pdbpp not correctly before - and wrote a test then.. ;) ref)

p.prompt = "(%s) " % self.prompt.strip()
self.message("ENTERING RECURSIVE DEBUGGER")
try:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2019-03-01-18-33-53.bpo-31078.Z214f3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Propogate ``use_rawinput`` to recursive pdb (pdb's debug command). Patch by
Segev Finer.