-
Notifications
You must be signed in to change notification settings - Fork 51
CA-340392 + minor script corrections #174
Conversation
- In PoSh $null should be on the left side of comparisons. - Aliases should be avoided. - Missing PassThru. Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
Signed-off-by: Konstantina Chremmou <[email protected]>
…n which the API call is run if the latter returns void. Signed-off-by: Konstantina Chremmou <[email protected]>
| an exposed XenAPI class. To specify the object to remove use the parameter | ||
| ‐T, where T is the exposed XenAPI class, or ‐Ref or, for those objects that | ||
| have a uuid or name, ‐UUID or ‐Name. Example: | ||
| -T, where T is the exposed XenAPI class, or -Ref or, for those objects that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice some changes around hyphens. Several symbols exist in UTF8 but not in Ascii, where we just have the minus, which is used for everything. Code that is pasted into the shell use the minus as otherwise it would not be recognised despite looking correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the old "hyphens" were in reality this character in UTF-16: \u00e2\u0080\u0090. I've turned them to minus.
|
An example in order to understand what the OCaml change does: Previously, calling the following cmdlet: i.e. the cmdldet returns the object on which the call was called. Which is not really necessary and it doesn't work for classes without records (e.g. Diagnostics). The change affects a big number of API calls returning void (they can be found by diffing the autogenerated code), but breaking user implementation may not be very likely as most users wouldn't expect a cmdlet to return the object for a call returning void. |
See commit messages for details. Commits best reviewed separately.