Add PVS_proxy module to Network_interface #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module contains metadata and functions to configure a PVS proxy daemon running on the host. Signed-off-by: Rob Hoes <[email protected]>
This was referenced Jul 7, 2016
| vdi: string; | ||
| } | ||
|
|
||
| external configure_farm : debug_info -> PVS_proxy.t -> unit = "" |
There was a problem hiding this comment.
Shouldn't this be t rather than PVS_proxy.t ?
Author
There was a problem hiding this comment.
You would be right if this were a normal ml file. However, xcp-idl transforms it in creative ways, such that this appears to be necessary.
Author
There was a problem hiding this comment.
For similar reasons I had to put the exception outside the module...
Collaborator
There was a problem hiding this comment.
What we should do is move to something less crazy... a ppx-based ocaml-rpc perhaps? :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module contains metadata and functions to configure a PVS proxy
daemon running on the host.
Signed-off-by: Rob Hoes [email protected]