Allow classmethods to return sub-classes #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
shouldn't we be using |
Collaborator
Author
|
I don't think so, because these are classmethods and therefore don't have a self argument. I took this solution from here: python/typing#254 (comment) |
Collaborator
|
i think the type checker will resolve |
Collaborator
Author
|
ooh okay, let me try |
Collaborator
Author
|
seems to work 👍 |
d-v-b
previously approved these changes
Dec 12, 2024
Collaborator
Author
|
Woops, I should have fixed the string casting in the latest commit. |
Collaborator
|
doctests are failing but that's not due to your changes. |
d-v-b
approved these changes
Dec 12, 2024
Collaborator
Author
|
Any chance of a release with this in? - would help with typing over at |
Collaborator
|
sure, I can put out a release tonight or tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
from_zarr()methods are not typed as returning sub-classes correctly. As a concrete example, this means that in this line:https://github.com/BioImageTools/ome-zarr-models-py/blob/4a6851ed1487a90274058dc92ebc3a16539557ed/tests/v04/test_hcs.py#L12
the
hcsvariable does not have the typeHCS, but instead a widerGroupSpectype.This PR should fix that so the from_zarr() methods are correctly typed for sub-classes.