Skip to content

Conversation

@0exbot
Copy link

@0exbot 0exbot commented Oct 28, 2022

Pull request from @c3b5aw.

awesome-graphql-security

GraphQL Security is a niche ecosystem which get more and more attention as GraphQL grow.

We decided to create an awesome list to push this ecosystem ahead and we already reached a lot of people (55+ stars, 6 contributors, following guildelines and automated workflows...).

[ boilerplate snipped ]

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-c3b5aw on 2022-07-25 08:50 says: unicorn

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-sindresorhus on 2022-07-25 14:42 says: Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-c3b5aw on 2022-07-26 15:36 says:

Thanks for making an Awesome list! raised_hands

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

Hello @-sindresorhus,

I reviewed the guidelines one more time and nothing related to the list itself is uncompliant.
May you share what you noticed?

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-bytecauldron on 2022-07-30 21:47 says: Hi @-c3b5aw,

Hope you are doing well. I noticed just a couple formatting-related issues but nothing too crazy.

  • Includes a project logo/illustration whenever possible. It might be a good idea to include a header image that links back to a relevant site (maybe GraphQL's official site?)
  • The table of contents needs a title. It should be titled "Contents".
  • The table of contents should not include the "Contributing" section.
  • The table of contents "Should only have one level of nested lists, preferably none."
  • Some of your listed links have a few grammatical errors. I see "graphQL" and "graphql" when it should be "GraphQL".
  • A few list descriptions do not end with a period.

Hope that helps. 😎

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-c3b5aw on 2022-07-30 22:37 says:

Hi @-c3b5aw,

Hope you are doing well. I noticed just a couple formatting-related issues but nothing too crazy.

* Includes a project logo/illustration whenever possible. It might be a good idea to include a header image that links back to a relevant site (maybe GraphQL's official site?)

* The table of contents needs a title. It should be titled "Contents".

* The table of contents should not include the "Contributing" section.

* The table of contents "Should only have one level of [nested lists](https://commonmark.org/help/tutorial/10-nestedLists.html), preferably none."

* Some of your listed links have a few grammatical errors. I see "graphQL" and "graphql" when it should be "GraphQL".

* A few list descriptions do not end with a period.

Hope that helps. sunglasses

Thanks for catching theses point. Will improve right away.

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-c3b5aw on 2022-07-30 22:51 says: Hello @-sindresorhus,

This is ready for review.

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-c3b5aw on 2022-09-11 10:15 says:

Hi,

Thanks for the list!

See just a few issues:

  1. Seems you don't review any PRs as for "You have to review at least 2 other open pull requests."

https://github.com/sindresorhus/awesome/pulls?q=type%3Apr+reviewed-by%3Ac3b5aw

  1. "GraphQL security frameworks, libraries, software and resources." it looks like a bad example from requirements "iOS - Resources and tools for iOS development."

It sounds as describing the list itself, which is not good.

You are reviewing a closed PR though.

@0exbot
Copy link
Author

0exbot commented Oct 28, 2022

@-alex-semenyuk on 2022-09-11 10:52 says: Sorry @-c3b5aw

Are you going to reopen it or it's closed forever?

I saw this

Hello @-sindresorhus,

This is ready for review.

and think that it's ready for review again

@akvadrako akvadrako merged commit 663aeb6 into main Oct 28, 2022
@akvadrako akvadrako deleted the pull/2335 branch October 28, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants