-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Add GraphQL Security #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL Security #2335
Conversation
|
unicorn |
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Hello @sindresorhus, I reviewed the guidelines one more time and nothing related to the list itself is uncompliant. |
|
Hi @c3b5aw, Hope you are doing well. I noticed just a couple formatting-related issues but nothing too crazy.
Hope that helps. 😎 |
Thanks for catching theses point. Will improve right away. |
|
Hello @sindresorhus, This is ready for review. |
alex-semenyuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for the list!
See just a few issues:
-
Seems you don't review any PRs as for "You have to review at least 2 other open pull requests."
https://github.com/sindresorhus/awesome/pulls?q=type%3Apr+reviewed-by%3Ac3b5aw -
"GraphQL security frameworks, libraries, software and resources." it looks like a bad example from requirements "iOS - Resources and tools for iOS development."
It sounds as describing the list itself, which is not good.
You are reviewing a closed PR though. |
|
Sorry @c3b5aw Are you going to reopen it or it's closed forever? I saw this
and think that it's ready for review again |
awesome-graphql-security
GraphQL Security is a niche ecosystem which get more and more attention as GraphQL grow.
We decided to create an awesome list to push this ecosystem ahead and we already reached a lot of people (55+ stars, 6 contributors, following guildelines and automated workflows...).
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List.Add SwiftAdd Software ArchitectureUpdate readme.mdAdd Awesome SwiftAdd swiftadd SwiftAdding SwiftAdded Swift- [iOS](…) - Mobile operating system for Apple phones and tablets.- [Framer](…) - Prototyping interactive UI designs.- [iOS](…) - Resources and tools for iOS development.- [Framer](…)- [Framer](…) - prototyping interactive UI designs#readme.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-linton your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main, notmaster.Mobile operating system for Apple phones and tablets.Prototyping interactive UI designs.Resources and tools for iOS development.Awesome Framer packages and tools.If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list.awesome-swiftawesome-web-typographyawesome-SwiftAwesomeWebTypography# Awesome Name of List.# Awesome Swift# Awesome Web Typography# awesome-swift# AwesomeSwiftawesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Contents, notTable of Contents.ContributingorFootnotessections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0(replace<user>and<repo>accordingly).licenseorLICENSEin the repo root with the license text.Licencesection to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn.contributing.md. Casing is up to you.Contributing, positioned at the top or bottom of the main content.Footnotessection at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.Node.js, notNodeJSornode.js.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-fooorInspired by the Awesome projectkinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.