Add compatibility for PostgreSQL 9.6 #204
Conversation
|
Fixing issues with the yum repo URL... |
| postgresql_version_terse: "{{ postgresql_version | replace('.', '') }}" | ||
| postgresql_yum_repository_base_url: "http://yum.postgresql.org" | ||
| postgresql_yum_repository_url: "{{ postgresql_yum_repository_base_url }}/{{ postgresql_version }}/{{ ansible_os_family | lower }}/rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}/pgdg-{{ postgresql_pgdg_dists[ansible_distribution] }}{{ postgresql_version_terse }}-{{ postgresql_version }}-2.noarch.rpm" | ||
| postgresql_yum_repository_url: "{{ postgresql_yum_repository_base_url }}/{{ postgresql_version }}/{{ ansible_os_family | lower }}/rhel-{{ ansible_distribution_major_version }}-{{ ansible_architecture }}/pgdg-{{ postgresql_pgdg_dists[ansible_distribution] }}{{ postgresql_version_terse }}-{{ postgresql_version }}-{{ postgresql_pgdg_releases.get(postgresql_pgdg_dists[ansible_distribution]).get(postgresql_version) }}.noarch.rpm" |
There was a problem hiding this comment.
Not a fan of this approach, but it works better than using "-2.noarch.rpm" in all cases (especially since 9.6 does not have a '2' release for Red Hat).
|
Resolves issue #203. |
arturmartins
left a comment
arturmartins
left a comment
There was a problem hiding this comment.
Could you add [*] as default value of postgresql_synchronous_standby_names, please?
templates/postgresql.conf-9.6.j2
Outdated
|
|
||
| # These settings are ignored on a standby server. | ||
|
|
||
| synchronous_standby_names = '{{postgresql_synchronous_standby_num_sync}} ({{postgresql_synchronous_standby_names|join(',')}})' # standby servers that provide sync rep |
There was a problem hiding this comment.
With the current default values, this line becomes:
synchronous_standby_names = '1 ()' # standby servers that provide sync rep
Unfortunately, it breaks postgres service.
There was a problem hiding this comment.
This parameter specifies a list of standby servers using either of the following syntaxes:
num_sync ( standby_name [, ...] ) # >= 9.6
standby_name [, ...] # < 9.6
https://www.postgresql.org/docs/9.6/static/runtime-config-replication.html
| # standby servers that provide sync rep. | ||
| # number of sync standbys (>= 9.6) and comma-separated list of application_name from standby(s) | ||
| postgresql_synchronous_standby_num_sync: 1 | ||
| postgresql_synchronous_standby_names: [] # '*' means 'all' |
There was a problem hiding this comment.
Would make sense to add '*' as default value?
|
Hi guys, When can we expect this PR to be merged? Thanks! |
|
Sorry, I need to reopen this pull request from a different fork of the repo. I'll make the requested changes and will open a new PR asap. |
|
#212 is the new PR. |
4 participants
Uh oh!
There was an error while loading. Please reload this page.