Skip to content

Add compatibility for PostgreSQL 9.6 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelConrad wants to merge 11 commits into from
Closed

Add compatibility for PostgreSQL 9.6 #204

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
896c0f9
Add compatibility for PostgreSQL 9.6
Oct 3, 2016
db130c9
Update .travis.yml for PostgreSQL 9.6
Oct 3, 2016
7d2ac15
Update test to use PostgreSQL 9.6
Oct 3, 2016
dc81e78
Update Ansible version in .travis.yml
Oct 3, 2016
ad8d40a
Update temp_file_limit comment due to better understanding of documen…
Oct 3, 2016
88fdf0b
Add distro / version specific release numbers to yum URL
Oct 3, 2016
a92bbaa
Fix typo in defaults/main.yml comment
Oct 3, 2016
13f852b
Add parameter for postgresql_synchronous_standby_num_sync
Oct 10, 2016
9e6746a
Remove extra single quotes
Oct 10, 2016
c99d889
Add single quotes to config template
Oct 10, 2016
d3d57c9
Handle synchronous_standby_names defaults better
Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add single quotes to config template
  • Loading branch information
Michael Conrad committed Oct 10, 2016
commit c99d88921ffc3458b98acb0422f22b7146e40a8a
2 changes: 1 addition & 1 deletion templates/postgresql.conf-9.6.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ track_commit_timestamp = {{'on' if postgresql_track_commit_timestamp else 'off'

# These settings are ignored on a standby server.

synchronous_standby_names = {{postgresql_synchronous_standby_num_sync}} ({{postgresql_synchronous_standby_names|join(',')}}) # standby servers that provide sync rep
synchronous_standby_names = '{{postgresql_synchronous_standby_num_sync}} ({{postgresql_synchronous_standby_names|join(',')}})' # standby servers that provide sync rep
Copy link

@arturmartins arturmartins Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current default values, this line becomes:

synchronous_standby_names = '1 ()' # standby servers that provide sync rep

Unfortunately, it breaks postgres service.

Copy link

@arturmartins arturmartins Oct 10, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter specifies a list of standby servers using either of the following syntaxes:

num_sync ( standby_name [, ...] )   # >= 9.6
standby_name [, ...]                # < 9.6

https://www.postgresql.org/docs/9.6/static/runtime-config-replication.html

# number of sync standbys and comma-separated list of application_name
# from standby(s); '*' = all
vacuum_defer_cleanup_age = {{postgresql_vacuum_defer_cleanup_age}} # number of xacts by which cleanup is delayed
Expand Down