-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix Retry strategy ShouldHandle in example code #2527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Retry strategy ShouldHandle in example code #2527
Conversation
|
@dotnet-policy-service agree |
|
Thanks for the PR. You'll need to change the code in the Snippets, which are used to generate the docs, otherwise the changes will get overwritten. Once you've done that the docs can be regenerated with: |
|
@martincostello Thanks for the pointer, good to go now? |
|
Looks like the snippet doesn't compile because it raises a nullability warning. |
6cc99ae to
a1cb5f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7327 7327
Branches 1013 1013
=======================================
Hits 7051 7051
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tweak the code formatting for changes from #2527.
Tweak the code formatting for changes from #2527.
Pull Request
The issue or feature being addressed
The existing example compiles, but incorrectly shows the
ShouldHandledelegate as operating on an Exception object.Details on the issue fix or feature implementation
Confirm the following