Skip to content

Fix Retry strategy ShouldHandle in example code #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martincostello merged 3 commits into from
Apr 7, 2025
+17 −14
Merged

Fix Retry strategy ShouldHandle in example code #2527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06e28b5
Fix ShouldHandle example
marcrocny Feb 22, 2025
b79a4d4
Fix retry-pattern-overusing-builder in snippet source
marcrocny Apr 5, 2025
a1cb5f3
retry snippets: fix null-ref warning; IDE0305 suggestion
marcrocny Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions docs/strategies/retry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,18 +474,18 @@ Use collections and simple predicate functions:

<!-- snippet: retry-pattern-overusing-builder -->
```cs
ImmutableArray<Type> networkExceptions = new[]
{
ImmutableArray<Type> networkExceptions =
[
typeof(SocketException),
typeof(HttpRequestException),
}.ToImmutableArray();
];

ImmutableArray<Type> strategyExceptions = new[]
{
ImmutableArray<Type> strategyExceptions =
[
typeof(TimeoutRejectedException),
typeof(BrokenCircuitException),
typeof(RateLimitRejectedException),
}.ToImmutableArray();
];

ImmutableArray<Type> retryableExceptions = networkExceptions
.Union(strategyExceptions)
Expand All @@ -494,7 +494,8 @@ ImmutableArray<Type> retryableExceptions = networkExceptions
var retry = new ResiliencePipelineBuilder()
.AddRetry(new()
{
ShouldHandle = ex => new ValueTask<bool>(retryableExceptions.Contains(ex.GetType())),
ShouldHandle = args
=> ValueTask.FromResult(args.Outcome.Exception != null && retryableExceptions.Contains(args.Outcome.Exception.GetType())),
MaxRetryAttempts = 3,
})
.Build();
Expand Down
16 changes: 9 additions & 7 deletions src/Snippets/Docs/Retry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,18 +174,18 @@ public static void Pattern_OverusingBuilder()
{
#region retry-pattern-overusing-builder

ImmutableArray<Type> networkExceptions = new[]
{
ImmutableArray<Type> networkExceptions =
[
typeof(SocketException),
typeof(HttpRequestException),
}.ToImmutableArray();
];

ImmutableArray<Type> strategyExceptions = new[]
{
ImmutableArray<Type> strategyExceptions =
[
typeof(TimeoutRejectedException),
typeof(BrokenCircuitException),
typeof(RateLimitRejectedException),
}.ToImmutableArray();
];

ImmutableArray<Type> retryableExceptions = networkExceptions
.Union(strategyExceptions)
Expand All @@ -194,7 +194,9 @@ public static void Pattern_OverusingBuilder()
var retry = new ResiliencePipelineBuilder()
.AddRetry(new()
{
ShouldHandle = ex => new ValueTask<bool>(retryableExceptions.Contains(ex.GetType())),
ShouldHandle = args
=> ValueTask.FromResult(args.Outcome.Exception is not null
&& retryableExceptions.Contains(args.Outcome.Exception.GetType())),
MaxRetryAttempts = 3,
})
.Build();
Expand Down