-
Notifications
You must be signed in to change notification settings - Fork 270
fix: keyboard shortcut formatting error fix. Fixes #416 #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keyboard shortcut formatting error fix. Fixes #416 #458
Conversation
|
Hey @Chandan-CV - Sorry about the delay, I'll take a look at this the coming weekend and test it out. The solution at first glance looks straightforward 👍 |
|
Thank you! |
|
Hi @Xazin! any updates on the PR? |
| end: selection.end.copyWith(offset: selection.end.offset), | ||
| ), | ||
| ).first == | ||
| " "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's abstract this to a const eg. const whiteSpaceCharacter = " ";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm on it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xazin, I refactored the code accordingly. Does it look right now?
Thank you!
|
@Chandan-CV Thank you for your contribution. I have implemented this feature by saving the toggled style. |
|
We have implemented a version of this 👍 |
|
That's a really clean implementation of the feature! Thank you for showing me how it's done :) |
This PR fixes the issue #416
Steps I took to fix the issue:
selection.lenght > 0demo:
Screencast.from.08-09-23.01.22.34.AM.IST.webm