Skip to content

Conversation

@LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Oct 11, 2023

Preview

Untitled.mp4
  • toggling the bold/underline/italic/strikethrough via cmd/ctrl + b/u/i/shift+s when the selection is collapsed.
  • canceling the bold/underline/italic/strikethrough via cmd/ctrl + b/u/i/shift+s when the selection is collapsed.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8a04d99) 80.17% compared to head (d8b69de) 80.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   80.17%   80.19%   +0.02%     
==========================================
  Files         282      282              
  Lines       11978    11993      +15     
==========================================
+ Hits         9603     9618      +15     
  Misses       2375     2375              
Files Coverage Δ
lib/src/core/transform/transaction.dart 92.21% <100.00%> (+0.03%) ⬆️
...k_component/rich_text/appflowy_rich_text_keys.dart 100.00% <100.00%> (ø)
lib/src/editor/command/text_commands.dart 87.78% <100.00%> (+0.90%) ⬆️
...ponent/service/ime/delta_input_on_insert_impl.dart 94.73% <100.00%> (+0.98%) ⬆️
...uts/command_shortcut_events/markdown_commands.dart 100.00% <100.00%> (ø)
lib/src/editor_state.dart 84.69% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit b17bddc into AppFlowy-IO:main Oct 11, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 12, 2023
* main:
  fix: unable to clear the style by toggling twice (AppFlowy-IO#532)
  fix: pinyin IME on Linux (AppFlowy-IO#531)
  fix: background color issues (AppFlowy-IO#530)
  fix: cursor blink at wrong location when inserting text (AppFlowy-IO#529)
  feat: enable toggling and canceling of the formatting with shortcuts (AppFlowy-IO#528)
  chore: bump version 1.4.4 (AppFlowy-IO#527)
  fix: the selection handles remain on the screen after cutting the text (AppFlowy-IO#526)
  fix: the selection should be clear if header or footer is focusing (AppFlowy-IO#525)
  feat: customize desktop toolbar style (AppFlowy-IO#519)
  feat: add regex and case sensitive to `FindReplaceMenu` (AppFlowy-IO#480)
  feat: export JSON in mobile and update mobile_example.json (AppFlowy-IO#515)
  feat: support customizing error block (AppFlowy-IO#524)
  fix: impossible to click on any sub-items if the top level item is off-screen (AppFlowy-IO#522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant