Skip to content

Conversation

@IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Jul 2, 2022

Currently the QPOS1 controller always accelerates away from home. This is to decelerate the vehicle based on the assumption that you will always be moving towards home and want to slow down. However if your not this causes issues, such as #21064

Take off in Qloiter, switch to loiter and then QRTL.
image

The vehicle is pushed away from home by this "deceleration".

This PR stops it doing that resulting in:

image

Once in the QPOS1 state it takes a more or less tangential path. This is better but still not really ideal.

I think the underlying problem is that were inputting velocity and acceleration. To calculate those velocity's and accelerations we have a limited position controller.

I think we should just be using the full position controller. However, we may need to add some functionality to allow overspeeds.

Just a draft because its not a great solution but does highlight the issue.

@tridge
Copy link
Contributor

tridge commented Jul 3, 2022

thanks @IamPete1 - I think for 4.3 we should aim to use the full pos controller, but I think we'll need support from @lthall for asymmetry, as we want to allow a lot more accel in -ve body X then we allow in (for example) body Y direction

@IamPete1
Copy link
Member Author

IamPete1 commented Sep 2, 2022

Replaced by #21620

@IamPete1 IamPete1 closed this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants