Plane: postition control QPOS1 and QPOS2 #31394
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #21620 to 4.7dev
This doesn't work like it should. In the old PR, the comment
is correct. But now after rebasing to 4.7, it's not quite working that way. Something with the input shaping has changed and now the target position is lagging significantly behind the actual position, causing the aircraft to pitch way back, then pitch forward again (4.7dev does this too, which I'm trying to fix in another PR, but if this PR can achieve the same result, it has other benefits).
backtransition_21620_4.7dev.zip
I get the behavior I want if I use
set_pos_vel_accel_NE_minstead ofinput_pos_vel_accel_NE_mon line 2603 but that's definitely not the right fix. Unfortunately, I don't understand the AC_PosControl library well enough. Hoping someone else sees something obvious here.