Skip to content

Conversation

@alploskov
Copy link
Contributor

AP_HAL_ChibiOS: add hwdef files for Aocoda-RC-F405

@Hwurzburg
Copy link
Contributor

needs readme and images per: https://ardupilot.org/dev/docs/readme_file.html#readme-file

Copy link
Contributor

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs README as well as some other changes

@@ -0,0 +1,38 @@
# hw definition file for processing by chibios_pins.py
# for speedybeef4 bootloader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong comment

FLASH_SIZE_KB 1024

# don't allow bootloader to use more than 16k
FLASH_USE_MAX_KB 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are constraining this to 16k but then further down you allow 64k - why the difference

PC8 TIM8_CH3 TIM8 PWM(3) GPIO(52)
PC9 TIM8_CH4 TIM8 PWM(4) GPIO(53) BIDIR
PA15 TIM2_CH1 TIM2 PWM(5) GPIO(54)
PA8 TIM1_CH1 TIM1 PWM(6) GPIO(55) BIDIR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I see the point of this. It ties up a DMA channel and you don't have bi-dir on 5, 7, 8. Be better to add it to 7&8 if you are going to do anything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and recheck DMA assignments for conflicts with IMU SPI devices

IMU Invensensev3 SPI:icm42688 ROTATION_YAW_90

# barometers
BARO DPS310 I2C:0:0x76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to disable the drivers by default and then just enable these to save a bit of flash

define BOARD_RSSI_ANA_PIN 13

# UARTs
PA9 USART1_TX USART1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have default protocols for these if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants