-
Notifications
You must be signed in to change notification settings - Fork 19.7k
AP_HAL_ChibiOS: add hwdef files for Aocoda-RC-F405 #31406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
needs readme and images per: https://ardupilot.org/dev/docs/readme_file.html#readme-file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs README as well as some other changes
| @@ -0,0 +1,38 @@ | |||
| # hw definition file for processing by chibios_pins.py | |||
| # for speedybeef4 bootloader | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong comment
| FLASH_SIZE_KB 1024 | ||
|
|
||
| # don't allow bootloader to use more than 16k | ||
| FLASH_USE_MAX_KB 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you are constraining this to 16k but then further down you allow 64k - why the difference
| PC8 TIM8_CH3 TIM8 PWM(3) GPIO(52) | ||
| PC9 TIM8_CH4 TIM8 PWM(4) GPIO(53) BIDIR | ||
| PA15 TIM2_CH1 TIM2 PWM(5) GPIO(54) | ||
| PA8 TIM1_CH1 TIM1 PWM(6) GPIO(55) BIDIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I see the point of this. It ties up a DMA channel and you don't have bi-dir on 5, 7, 8. Be better to add it to 7&8 if you are going to do anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and recheck DMA assignments for conflicts with IMU SPI devices
| IMU Invensensev3 SPI:icm42688 ROTATION_YAW_90 | ||
|
|
||
| # barometers | ||
| BARO DPS310 I2C:0:0x76 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to disable the drivers by default and then just enable these to save a bit of flash
| define BOARD_RSSI_ANA_PIN 13 | ||
|
|
||
| # UARTs | ||
| PA9 USART1_TX USART1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have default protocols for these if possible.
AP_HAL_ChibiOS: add hwdef files for Aocoda-RC-F405