ardupilotwaf: consolidate hwdef result processing #31423
Merged
+46
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Environment variables are `[]` by default if mutated or specifically checked, so existing e.g. `+=` will still work. However, a check if the variable exists will now fail.
The merging logic is no longer necessary since we aren't re-running the generator and merging its results multiple times per build. Also allows ChibiOS-specific ROMFS_FILES handling to be removed as it's now handled automatically. No boards in tree try to redefine an existing variable.
|
This is another sequel to #31096 . |
|
@peterbarker can you check this is no output change? if so can be merged |
Confirmed no compiler output change on Linux or ChibiOS boards. |
peterbarker
approved these changes
Nov 4, 2025
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling on more loose threads to clean up and simplify waf. Please see commit messages for details.
Confirmed that all in-tree hwdefs for all supported boards still configure. Also confirmed no compiler output change for an arbitrary board for each of ChibiOS, ESP32, and Linux.