Skip to content

Conversation

@peterbarker
Copy link
Contributor

@peterbarker peterbarker commented Nov 2, 2025

Stops using "ifdef" defines.

Removes the somewhat odd #ifdef HAL_COMPASS_DISABLE_IST8310_INTERNAL_PROBE.

Removes double-negatives.

Output changes:

pbarker@threads:~/rc/ardupilot$ ./Tools/scripts/filter_size_compare_branches_csv.py --hide /tmp/some.csv 
------------------------  -----  ------  ----  -----  -----  ---
Board                     blimp  copter  heli  plane  rover  sub
SITL_arm_linux_gnueabihf  0      0       80    48     16     -64
SITL_x86_64_linux_gnu     0      0       0     0      0      0
aero                      -48    0       -32   48     48     0
bebop                            96
dark                      32     -144    0     0      -48    -32
disco                                          0
linux                     0      0       0     0      0      0
vnav                      0      0       0     -48    0      48
------------------------  -----  ------  ----  -----  -----  ---

The Linux boards aren't losing any symbols, the changes seem to centre around paths getting embedded in compiler products.

@peterbarker peterbarker changed the title Pr/compass probing defines Tidy compass probing defines Nov 2, 2025
Copy link
Contributor

@tpwrules tpwrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inexplicably has #31424 mixed in but otherwise looks okay with a brief check (this statement does not constitute an approving review).

Poor Bob :(

@peterbarker peterbarker force-pushed the pr/compass-probing-defines branch from 837870e to 4b6de6f Compare November 2, 2025 05:30
Bob can handle his own problems
 - stop using #ifdef defines
 - use current standard naming schemes
 - remove the double-negatives
 - stop using #ifdef defines
 - use current standard naming schemes
 - remove the double-negatives
 - stop using #ifdef defines
 - use current standard naming schemes
 - remove the double-negatives
@peterbarker peterbarker force-pushed the pr/compass-probing-defines branch 2 times, most recently from cd0da7a to be15878 Compare November 2, 2025 09:47
@peterbarker
Copy link
Contributor Author

This inexplicably has #31424 mixed in but otherwise looks okay with a brief check (this statement does not constitute an approving review).

Those patches are gone; my build-everything routine showed up the pocket2 problem, and I finally broke and fixed the problem :-)

Poor Bob :(

He had it coming.

Copy link
Contributor

@tpwrules tpwrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed some no compiler output changes.

@tridge tridge merged commit 7109396 into ArduPilot:master Nov 5, 2025
106 of 107 checks passed
@peterbarker peterbarker deleted the pr/compass-probing-defines branch November 5, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants