-
Notifications
You must be signed in to change notification settings - Fork 19.7k
Tidy compass probing defines #31425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy compass probing defines #31425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This inexplicably has #31424 mixed in but otherwise looks okay with a brief check (this statement does not constitute an approving review).
Poor Bob :(
837870e to
4b6de6f
Compare
Bob can handle his own problems
- stop using #ifdef defines - use current standard naming schemes - remove the double-negatives
- stop using #ifdef defines - use current standard naming schemes - remove the double-negatives
- stop using #ifdef defines - use current standard naming schemes - remove the double-negatives
cd0da7a to
be15878
Compare
Those patches are gone; my build-everything routine showed up the pocket2 problem, and I finally broke and fixed the problem :-)
He had it coming. |
tpwrules
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, confirmed some no compiler output changes.
Stops using "ifdef" defines.
Removes the somewhat odd
#ifdef HAL_COMPASS_DISABLE_IST8310_INTERNAL_PROBE.Removes double-negatives.
Output changes:
The Linux boards aren't losing any symbols, the changes seem to centre around paths getting embedded in compiler products.