autotest: remove several pointless try/except blocks #31429
Conversation
|
Hinted at by #30574 |
|
I have had to ask people to remove pointless push/pop in several PRs. This PR best seen with "Hide whitespace" set. |
|
It looks like this broke at least one test? Is it possible to split this up into one commit per test? |
peterbarker
force-pushed
the
pr/remove-pointless-try-except
branch
from
ca42605 to
d8c1214
Compare
I removed that one from this PR.
Yes, but I'd rather not as the changes are all very similar and we don't want to have vast numbers of commits. Bearing in mind there are probably 100 more places we could do the same sort of thing in the suite. I really just did do a grep and look at individual cases here to get an idea of how the PR I linked above involves fixing. |
the infrastructure now takes care of all of this cleanup. Particularly when reboots are involved removing these can make things faster
peterbarker
force-pushed
the
pr/remove-pointless-try-except
branch
from
d8c1214 to
d7ca8cc
Compare
tpwrules
left a comment
tpwrules
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks for the review tip. Surely lots more clean up to be done and documentation on what a test can expect from the harness :)
2 participants
the infrastructure now takes care of all of this cleanup.
Particularly when reboots are involved removing these can make things faster