Tools: remove absolute path reference to rm command
#31431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some systems (e.g. NixOS) it's not there.
khancyr
reviewed
Nov 3, 2025
| """Run one step.""" | ||
| # remove old logs | ||
| util.run_cmd('/bin/rm -f logs/*.BIN logs/LASTLOG.TXT') | ||
| util.run_cmd('rm -f logs/*.BIN logs/LASTLOG.TXT') |
There was a problem hiding this comment.
shouldn't we use the python rm instead ? that would improve compatibility and safety ?
There was a problem hiding this comment.
Yes, probably. I will definitely review any PR which bring that in - but in the meantime this unbreaks this for Thomas, so I do intend to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems (e.g. NixOS) it's not there.