Update Google fonts list to include fonts from Jetpack #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Was about to deploy this but hesitant due to performance issues in another implementation (Automattic/jetpack#28119) that need fixing, and I haven't dug deeper into how this feature was implemented. Could be similar problems. |
Member
Author
|
Do these fonts actually get exposed anywhere anymore? Can't find the UI. With classic, non FSE theme:
|
|
Closing this ticket, but the user will need an update once this is complete: 5802740-zd-woothemes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes font list from Jetpack Global Styles implementation which I've also just updated to include new fonts..
See p9Jlb4-5Dj-p2 for design discussion.