Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Nov 16, 2022

Adding a set of new fonts.

See p9Jlb4-5Dj-p2 for design discussion.

image

Changes proposed in this Pull Request:

  • Cleans up the list a bit (" to ' and alphabetical order)
  • Adds new fonts:

Sans Serif fonts

Serif Fonts

Monospace font

Unlike in the screenshot above and the P2, these two fonts were omitted as they aren't Google Fonts:

  • Uncut Sans
  • Metropolis

We'll need to look at how to add them separately.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • In site editor, go to "global styles" panel and change fonts. See new fonts available

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 3, 2023.
  • Scheduled code freeze: December 26, 2022.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/fonts to get started. More details: p9dueE-5Nn-p2

This was referenced Dec 5, 2022
@simison simison marked this pull request as ready for review December 6, 2022 18:53
@simison simison added the [Status] Needs Review This PR is ready for review. label Dec 6, 2022
@simison simison force-pushed the update/fonts branch 2 times, most recently from 939d894 to 664daa0 Compare December 9, 2022 11:46
jeherve
jeherve previously approved these changes Dec 9, 2022
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Normal and removed [Status] Needs Review This PR is ready for review. labels Dec 9, 2022
@jeherve jeherve added this to the Jetpack 11.7 milestone Dec 9, 2022
@simison simison requested a review from pbking December 9, 2022 13:39
@simison simison added the [Status] Needs Review This PR is ready for review. label Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Google Fonts [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants