Skip to content

Remove Composer Installers #12479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 1 commit into from
May 28, 2019
Merged

Remove Composer Installers #12479

jeherve merged 1 commit into from
May 28, 2019

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented May 28, 2019

Changes proposed in this Pull Request:

  • Those are not used by Jetpack

Testing instructions:

  • There should not be too much to test.
  • Make sure Jetpack can still be loaded.

Proposed changelog entry for your changes:

  • None

@jeherve
Remove Composer Installers
1ca3bf7 
Those are not used by Jetpack
@jeherve jeherve added this to the 7.4 milestone May 28, 2019
@jeherve jeherve requested a review from a team May 28, 2019 18:06
@jeherve jeherve self-assigned this May 28, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented May 28, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 1ca3bf7

@oskosk oskosk added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 28, 2019
@jeherve jeherve merged commit e0d6e49 into master May 28, 2019
@jeherve jeherve deleted the rm/composer-installers branch May 28, 2019 18:19
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 28, 2019
jeherve added a commit that referenced this pull request May 28, 2019
@jeherve
Remove Composer Installers (#12479)
7c29b45 
Those are not used by Jetpack
@jeherve
Copy link
Member Author

jeherve commented May 28, 2019

Cherry-picked to branch-7.4 in 7c29b45

jeherve added a commit that referenced this pull request Jun 21, 2019
@jeherve
Remove Composer installers
9ecf160 
Those were already removed in #12479, but were added back by mistake in #12399
@jeherve jeherve mentioned this pull request Jun 21, 2019
Merged
jeherve added a commit that referenced this pull request Jun 21, 2019
@jeherve
Remove Composer installers (#12807)
d7250a1 
Those were already removed in #12479, but were added back by mistake in #12399
jeherve added a commit that referenced this pull request Jun 21, 2019
@jeherve
Remove Composer installers (#12807)
4a55a2a 
Those were already removed in #12479, but were added back by mistake in #12399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezama lezama lezama approved these changes

+1 more reviewer

@oskosk oskosk oskosk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

[Focus] Jetpack DNA [Type] Janitorial

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

6 participants

@jeherve @jetpackbot @lezama @oskosk @matticbot