Skip to content

Remove Composer installers #12807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeherve merged 1 commit into from
Jun 21, 2019
Merged

Remove Composer installers #12807

jeherve merged 1 commit into from
Jun 21, 2019

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Jun 21, 2019

Changes proposed in this Pull Request:

Testing instructions:

  • Not much really. Try yarn build, and make sure Jetpack still loads.

Proposed changelog entry for your changes:

  • None

@jeherve
Remove Composer installers
9ecf160 
Those were already removed in #12479, but were added back by mistake in #12399
@jeherve jeherve added this to the 7.5 milestone Jun 21, 2019
@jeherve jeherve requested review from a team and zinigor June 21, 2019 09:49
@jeherve jeherve self-assigned this Jun 21, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Jun 21, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 9ecf160

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jun 21, 2019
@jeherve jeherve merged commit d7250a1 into master Jun 21, 2019
@jeherve jeherve deleted the rm/composer-installers-again branch June 21, 2019 10:48
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 21, 2019
jeherve added a commit that referenced this pull request Jun 21, 2019
@jeherve
Remove Composer installers (#12807)
4a55a2a 
Those were already removed in #12479, but were added back by mistake in #12399
@jeherve
Copy link
Member Author

jeherve commented Jun 21, 2019

Cherry-picked to branch-7.5 in 4a55a2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zinigor zinigor Awaiting requested review from zinigor

1 more reviewer

@brbrr brbrr brbrr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

[Pri] BLOCKER [Type] Janitorial

Projects

None yet

Milestone

7.5

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @brbrr @matticbot