Convert Jetpack_XMLRPC_Server to a classmapped package

[mdawaffe]

Fixes #12538

Changes proposed in this Pull Request:

• Moves class.jetpack-xmlrpc-server.php to packages/xmlrpc-server.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

N/A

Testing instructions:

• phpunit --filter=WP_Test_Jetpack_XMLRPC_Server

Proposed changelog entry for your changes:

None required.

TODO

• Move tests to package
• Resolve dependencies (JetpackTracking, Jetpack_Options, Jetpack, Jetpack_Error, Jetpack_Client_Server, Jetpack_IXR_Client, WP_Error, IXR_Error, Jetpack_Data, WPCOM_JSON_API, …?)

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 8e0ceb4

[mdawaffe]

I don't think this is the right approach. Rather than a package that provides all the XML-RPC methods, we should have a package that makes it easy to register XML-RPC methods:

namespace ….

class XMLRPC_Server_Methods {
  public function add( string $method_name, array $auth_reqs, callable $callback ) {
    /*
     * $auth_reqs looks something like:
     * [
     *     'public' => (bool), // can be accessed without auth?
     *     'blog'   => (bool), // can be accessed with just a Blog Token?
     *     'user'   => (bool), // requires a User Token?
     * ]
     */
  }
}

Then this package wouldn't have to worry about any dependencies of its own.

[mdawaffe]

I think we can hold off on this until #12630 settles. It may be this PR isn't needed.

[lezama]

why not

[lezama]

hmm, merged to the wrong branch, @dereksmart @jeherve shouldn't we delete feature/jetpack-packages?