-
Notifications
You must be signed in to change notification settings - Fork 846
Connection "Connectors" #12630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection "Connectors" #12630
Conversation
Pull the site registration API methods/endpoints out into their own connector classes: one for XML-RPC, one for REST.
|
This PR looks like it might contain user tracking functions. We need to make sure that it is GDPR Compliant. Rules triggering this positive scan:
cc: @pesieminski |
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: July 2, 2019. |
|
This PR looks like it might contain user tracking functions. We need to make sure that it is GDPR Compliant. Rules triggering this positive scan:
cc: @pesieminski |
zinigor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is going, let's merge this and continue in the feature branch.
Changes proposed in this Pull Request:
Adds a class to the Connection package for each of the XML-RPC and REST API connection methods/endpoints.
Currently only handles site registration, not user registration, disconnection, etc.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
N/A
Testing instructions:
composer installProposed changelog entry for your changes:
None required.