Skip to content

Conversation

@mdawaffe
Copy link
Member

@mdawaffe mdawaffe commented Jun 8, 2019

Changes proposed in this Pull Request:

Adds a class to the Connection package for each of the XML-RPC and REST API connection methods/endpoints.

Currently only handles site registration, not user registration, disconnection, etc.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

N/A

Testing instructions:

  • composer install
  • Disconnect and reconnect

Proposed changelog entry for your changes:

None required.

mdawaffe added 2 commits June 7, 2019 20:12
Pull the site registration API methods/endpoints out into their own
connector classes: one for XML-RPC, one for REST.
@mdawaffe mdawaffe requested a review from a team June 8, 2019 03:26
@matticbot
Copy link
Contributor

This PR looks like it might contain user tracking functions. We need to make sure that it is GDPR Compliant.

Rules triggering this positive scan:

  • Called "record_user_event" function.

cc: @pesieminski

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jun 8, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 5a60382

@matticbot
Copy link
Contributor

This PR looks like it might contain user tracking functions. We need to make sure that it is GDPR Compliant.

Rules triggering this positive scan:

  • Called "record_user_event" function.

cc: @pesieminski

Copy link
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is going, let's merge this and continue in the feature branch.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress labels Jun 11, 2019
@dereksmart dereksmart merged commit 6d51bfb into feature/jetpack-packages-2 Jun 11, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 11, 2019
@dereksmart dereksmart deleted the try/xmlrpc-and-rest-connectors branch June 11, 2019 13:30
dereksmart pushed a commit that referenced this pull request Jun 11, 2019
* Connection API "Connector" classes.

Pull the site registration API methods/endpoints out into their own
connector classes: one for XML-RPC, one for REST.

* PHPCS

* Oops - make the signatures match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants