Skip to content

Merges connection "Connectors" work into the master branch. #12654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dereksmart merged 1 commit into from
Jun 11, 2019
Merged

Merges connection "Connectors" work into the master branch. #12654

dereksmart merged 1 commit into from
Jun 11, 2019

Conversation

@zinigor
Copy link
Contributor

@zinigor zinigor commented Jun 11, 2019

The connectors work should have been merged into master instead of the feature branch, so this PR brings the changes into master. The original PR is #12630.

Pull the site registration API methods/endpoints out into their own connector classes: one for XML-RPC, one for REST.

Changes proposed in this Pull Request:

  • Adds connectors as separate classes for connection purposes.

Testing instructions:

  • Make sure you can connect/disconnect your Jetpack site using this version.

Proposed changelog entry for your changes:

  • N/A

@mdawaffe @dereksmart
Connection "Connectors" (#12630)
6d51bfb 
* Connection API "Connector" classes.

Pull the site registration API methods/endpoints out into their own
connector classes: one for XML-RPC, one for REST.

* PHPCS

* Oops - make the signatures match
@zinigor zinigor added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Ready to Merge Go ahead, you can push that green button! [Focus] Jetpack DNA labels Jun 11, 2019
@zinigor zinigor requested a review from a team June 11, 2019 19:35
@matticbot
Copy link
Contributor

matticbot commented Jun 11, 2019

This PR looks like it might contain user tracking functions. We need to make sure that it is GDPR Compliant.

Rules triggering this positive scan:

  • Called "record_user_event" function.

cc: @pesieminski

@jeherve jeherve added this to the 7.5 milestone Jun 11, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Jun 11, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 6d51bfb

@dereksmart dereksmart merged commit b52fa91 into master Jun 11, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 11, 2019
@dereksmart dereksmart deleted the merge/connectors-into-master branch June 11, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dereksmart dereksmart dereksmart approved these changes

Assignees

No one assigned

Labels

[Focus] Jetpack DNA [Status] Needs GDPR Review [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Milestone

7.5

Development

Successfully merging this pull request may close these issues.

7 participants

@zinigor @matticbot @jetpackbot @dereksmart @jeherve @mdawaffe