Masterbar: Add caching to the API call for the My Home link #13791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're adding a My Home link to the sidebar options, but that involves an API call to wpcom. This stores the result in a transient, so we don't need to keep checking if a site is eligible for My Home or not.
jeherve
added
the
[Feature] Masterbar
pablinos
changed the title
creativecoder
force-pushed
the
add/masterbar--my-home
branch
from
1f79d79 to
d05cf44
Compare
Contributor
|
Thank you! I've incorporated this into #13757 |
Contributor
Author
|
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
We're adding a My Home link to the sidebar options, but that involves an
API call to wpcom. This stores the result in a transient, so we don't
need to keep checking if a site is eligible for My Home or not.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Load an admin page for a test site and check that the
jetpack_my_home_enabledtransient is set correctly.