Skip to content

Conversation

@creativecoder
Copy link
Contributor

@creativecoder creativecoder commented Oct 15, 2019

Changes proposed in this Pull Request:

  • Adds the Customer Home link to the Masterbar for Atomic sites to keep parity with Calypso sidebar

This PR depends on

Update: these dependencies have now been merged

Is this a new feature or does it add/remove features to an existing part of Jetpack?

See pb5gDS-2L-p2 for context

Testing instructions:

  • Create a new Jetpack site (must be created on or after 2019-08-06) and connect to WordPress.com
  • Install wpcomsh as a mu-plugin to emulate an Atomic Site
  • When clicking on "My Sites" in the master bar, you should see "My Home" added

Alternatively, you can edit the Registered date of the Jetpack cached site at /wp-admin/network/site-info.php?id=SITE_ID to be after 2019-08-06.

Proposed changelog entry for your changes:

  • Adds "My Home" link to Masterbar for sites hosted on WordPress.com

@creativecoder creativecoder added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Status] In Progress labels Oct 15, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Oct 15, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against 533712f

@creativecoder creativecoder added [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] In Progress labels Nov 25, 2019
@creativecoder
Copy link
Contributor Author

Now that D34250-code and #13844 have landed, this is ready for review.

@jeherve jeherve added this to the 8.1 milestone Nov 25, 2019
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 11, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me, it should be good to merge. I only added tracking to the link in 533712f

@jeherve jeherve merged commit 2b82513 into master Dec 13, 2019
@jeherve jeherve deleted the add/masterbar--my-home branch December 13, 2019 08:17
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 13, 2019
@creativecoder
Copy link
Contributor Author

Thanks for merging @jeherve !

jeherve added a commit that referenced this pull request Dec 13, 2019
zinigor added a commit that referenced this pull request Dec 30, 2019
* Changelog: 8.1 additions

* Changelog: add #13858

* Changelog: add #13963

* Changelog: add #14174

* Changelog: add #14178

* Changelog: add #14175

* Changelog: add #14192

* Changelog: add #14196

* Changelog: add #14182

* Changelog: add #14218

* Changelog: add #14214

* Changelog: add #13757

* Changelog: add #14190

* Changelog: add #14131

* Changelog: add #14101

* Changelog: add #14203

* Changelog: add #14211

* Changelog: add #14224

* Changelog: add #14230

* Changelog: add #14241

* Changelog: add #14249

* Changelog: add #14264

* Changelog: add #14263

* Changelog: add #14256

* Changelog: add #10189

* Changelog: add #14240

* Changelog: add #14239

Also added some new entries to the testing file.

Co-authored-by: Igor Zinovyev <[email protected]>
zinigor added a commit that referenced this pull request Dec 30, 2019
* Changelog: 8.1 additions

* Changelog: add #13858

* Changelog: add #13963

* Changelog: add #14174

* Changelog: add #14178

* Changelog: add #14175

* Changelog: add #14192

* Changelog: add #14196

* Changelog: add #14182

* Changelog: add #14218

* Changelog: add #14214

* Changelog: add #13757

* Changelog: add #14190

* Changelog: add #14131

* Changelog: add #14101

* Changelog: add #14203

* Changelog: add #14211

* Changelog: add #14224

* Changelog: add #14230

* Changelog: add #14241

* Changelog: add #14249

* Changelog: add #14264

* Changelog: add #14263

* Changelog: add #14256

* Changelog: add #10189

* Changelog: add #14240

* Changelog: add #14239

Also added some new entries to the testing file.

Co-authored-by: Igor Zinovyev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants