Skip to content

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Jul 7, 2020

Jetpack 8.7 moved UA detection to a new package. There are some themes that, improperly, accessed the legacy methods statically.

In 8.7, the refactor would result in fatals for sites doing this.

Changes proposed in this Pull Request:

  • Restore backcompat for themes calling methods statically. (Pre-existing notices would still fire.)

Jetpack product discussion

No.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Install pub/p2-breathe theme.

Proposed changelog entry for your changes:

  • Backwards Compatibility: Prevent fatals on themes calling a method statically.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Jul 7, 2020
@kraftbj kraftbj added this to the 8.7.1 milestone Jul 7, 2020
@kraftbj kraftbj self-assigned this Jul 7, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Jul 7, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16430

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 3bd5505

@kraftbj kraftbj force-pushed the restore/back-compat-user-agent branch from 6c775f8 to 0ef579e Compare July 7, 2020 21:09
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D46076-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@kraftbj kraftbj force-pushed the restore/back-compat-user-agent branch from 0ef579e to d3f1ab4 Compare July 8, 2020 14:57
@kraftbj kraftbj added the [Status] Needs Review This PR is ready for review. label Jul 8, 2020
@kraftbj kraftbj requested review from dereksmart, dero and jeherve and removed request for jeherve July 8, 2020 15:07
@kraftbj kraftbj removed the request for review from dero July 8, 2020 15:17
Copy link
Contributor

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kraftbj kraftbj merged commit e7d0ac8 into master Jul 8, 2020
@kraftbj kraftbj deleted the restore/back-compat-user-agent branch July 8, 2020 21:50
@matticbot matticbot removed the [Status] Needs Review This PR is ready for review. label Jul 8, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Jul 8, 2020

Cherry-picked to branch-8.7 via ac064db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Jetpack DNA Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants