Skip to content

User Agent: Restore back-compat #16430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraftbj merged 4 commits into from
Jul 8, 2020
Merged

User Agent: Restore back-compat #16430

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3f1ab4
Add failing test for 8.7 BC break for UA deteection
kraftbj Jul 7, 2020
a5e228b
Restore BC for UA detection functions
kraftbj Jul 8, 2020
9752bf7
Improve PHP DocBlocks
kraftbj Jul 8, 2020
3bd5505
Fix whitespacing 🤦‍♂️
kraftbj Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add failing test for 8.7 BC break for UA deteection
  • Loading branch information
@kraftbj
kraftbj committed Jul 8, 2020
commit d3f1ab472e924ed81e8159cae85a33b1270353e8
27 changes: 27 additions & 0 deletions tests/php/general/test_class.jetpack-user-agent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?php // phpcs:ignore WordPress.Files.FileName
/**
* Tests for Jetpack's legacy User Agent class.
*
* @package Jetpack.
*/

/**
* Class WP_Test_Jetpack_User_Agent
*/
class WP_Test_Jetpack_User_Agent extends WP_UnitTestCase {
/**
* Confirm an old improper static use of Jetpack_User_Agent_Info still functions.
*/
public function test_jetpack_user_agent_is_tablet() {
$this->setExpectedDeprecated( 'Jetpack_User_Agent_Info::is_tablet' );
$this->assertFalse( Jetpack_User_Agent_Info::is_tablet() );
}

/**
* Confirm an old improper static use of Jetpack_User_Agent_Info still functions.
*/
public function test_jetpack_user_agent_is_iphoneOrIpod() {
$this->setExpectedDeprecated( 'Jetpack_User_Agent_Info::is_iphoneOrIpod' );
$this->assertFalse( Jetpack_User_Agent_Info::is_iphoneOrIpod() );
}
}