Form Block: add new variation allowing site email collection

[jeherve]

Changes proposed in this Pull Request:

• Let's expand the form block to add a new option allowing folks to collect email addresses for their site.

Jetpack product discussion

• Internal reference: p1HpG7-9NB-p2

Does this pull request change what data or activity we track or use?

• N/A

Testing instructions:

• Go to Posts > Add New
• Search for block.
• See the new form option:

• Type /form
• See the new option

Proposed changelog entry for your changes:

• N/A

[test-case-reminder]

Here are some suggested test cases for this PR.

Contact Form

• Publish a post with default form block
• Edit a post that includes a block that was created with a previous version of the plugin
• Submit a form via frontend using form block
• Check different predefined form types
• Verify it renders as expected in both non-AMP and AMP views
• Check in mobile view
• Check in a older version of WordPress
• Check with the Gutenberg plugin
• Check without the Gutenberg plugin
• Check in IE11

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D47035-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16606

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 787efe4

[ebinnion]

@Automattic/jetpack-design – This PR is to support the Creativ.eMail block that is discussed in p1HpG7-9NB-p2. The question that I have here is whether "Signup Form" is the correct name to use for this form variant? The first thing that came to mind for me was "Subscription Form".

On another note, do we have hooks on the backend that we can use to distinguish these form block variants? For example, it'd be nice to be able to drop this form in a page and then on the backend listen to something like jetpack_form_submission_$variant, or jetpack_form_submission_subscription_form.

[folletto]

The question that I have here is whether "Signup Form" is the correct name to use for this form variant? The first thing that came to mind for me was "Subscription Form".

Yeah I agree, signup doesn't seem the right operation here, and depending on the context might be misleading.
I would need some context on what each of these options do before answering, but overall, I think that's a sensible suggestion.

[jeherve]

On another note, do we have hooks on the backend that we can use to distinguish these form block variants? For example, it'd be nice to be able to drop this form in a page and then on the backend listen to something like jetpack_form_submission_$variant, or jetpack_form_submission_subscription_form.

Not yet, no. Once we start making progress on this, I was thinking about adding an additional attribute to the form, just like we did in #16519 for Jetpack CRM, and set that attribute to true when a form has an integration. We have access to those attributes when we build the form, so we can use that to add an extra field to the form submission if the attribute is set.

[jeherve]

closing in favor of #16808.