Skip to content

Conversation

@marekhrabe
Copy link
Contributor

@marekhrabe marekhrabe commented Jul 28, 2020

Fixes #16594

TODO:

  • install @automattic/social-previews into Jetpack
  • find a place for social previews feature and create a scaffolding
  • mark extension as beta

Changes proposed in this Pull Request:

  • adds very basic scaffolding and place where we'll later put our code

Jetpack product discussion

Does this pull request change what data or activity we track or use?

no

Testing instructions:

yarn build-extensions to build the corresponding bundle

For working on this feature, set constants in wp-config:

define( 'WP_DEBUG', true );
define( 'JETPACK_BETA_BLOCKS', true );
define( 'JETPACK_DEV_DEBUG', true );
define( 'SCRIPT_DEBUG', true );
define( 'GUTENBERG_DEVELOPMENT_MODE', true );
  • Load the block editor and lookup window.Jetpack_Editor_Initial_State.available_blocks['social-previews']
  • it should return { available: true }

No other UI is expected at this point, we have them as separate tasks.

Proposed changelog entry for your changes:

  • none yet

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello marekhrabe! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D47085-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jul 28, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16615

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 6664aeb

jeherve
jeherve previously approved these changes Jul 29, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on my end. 👍

image

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jul 29, 2020
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marekhrabe for creating a progressive PR 👍 !
Tested by instructions and can confirm the following:

  • running yarn build adds the npm package without any notices and the environment continues to work
  • setting the wp-config.php constants and running in the console window.Jetpack_Editor_Initial_State.available_blocks['social-previews'] returns { available: true } (works for @marekhrabe and @jeherve )

What do you think about renaming it to social-reviews-panel since we already have a social-reviews package that will be used from the panel?

Also, left some comments

@marekhrabe
Copy link
Contributor Author

What do you think about renaming it to social-reviews-panel since we already have a social-reviews package that will be used from the panel?

@jeherve what's your take on this? I would prefer to keep the current name. No other feature/block contain word that describes where the feature shows up. It's always equal to just the name of the feature

@marekhrabe marekhrabe added the [Status] Needs Review This PR is ready for review. label Jul 29, 2020
@jeherve
Copy link
Member

jeherve commented Jul 29, 2020

what's your take on this? I would prefer to keep the current name. No other feature/block contain word that describes where the feature shows up. It's always equal to just the name of the feature

Yes, I would agree. I think social-previews works here.

@jeherve jeherve removed the [Status] Needs Review This PR is ready for review. label Jul 29, 2020
@jeherve jeherve removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Jul 31, 2020
@marekhrabe marekhrabe merged commit 429c84e into master Aug 3, 2020
@marekhrabe marekhrabe deleted the add/social-previews-scaffolding branch August 3, 2020 09:15
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 3, 2020
@jeherve
Copy link
Member

jeherve commented Aug 5, 2020

r211491-wpcom

pereirinha pushed a commit that referenced this pull request Sep 10, 2020
* add social-previews dependency

* updated yarn after installing deps

* add social-previews feature

* change class to function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(3P) Social Previews: Add scaffolding for the feature

6 participants