-
Notifications
You must be signed in to change notification settings - Fork 847
Social Preview: Add scaffolding for the feature #16615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16615 Scheduled Jetpack release: August 4, 2020. |
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpapazoglou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marekhrabe for creating a progressive PR 👍 !
Tested by instructions and can confirm the following:
- running
yarn buildadds the npm package without any notices and the environment continues to work - setting the
wp-config.phpconstants and running in the consolewindow.Jetpack_Editor_Initial_State.available_blocks['social-previews']returns{ available: true }(works for @marekhrabe and @jeherve )
What do you think about renaming it to social-reviews-panel since we already have a social-reviews package that will be used from the panel?
Also, left some comments
@jeherve what's your take on this? I would prefer to keep the current name. No other feature/block contain word that describes where the feature shows up. It's always equal to just the name of the feature |
Yes, I would agree. I think |
|
r211491-wpcom |
* add social-previews dependency * updated yarn after installing deps * add social-previews feature * change class to function

Fixes #16594
TODO:
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
no
Testing instructions:
yarn build-extensionsto build the corresponding bundleFor working on this feature, set constants in wp-config:
window.Jetpack_Editor_Initial_State.available_blocks['social-previews']{ available: true }No other UI is expected at this point, we have them as separate tasks.
Proposed changelog entry for your changes: