Social Previews: Upgrade Nudge in Modal #16744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpapazoglou
suggested changes
Aug 7, 2020
Contributor
cpapazoglou
left a comment
cpapazoglou
left a comment
There was a problem hiding this comment.
Thanks @marekhrabe for your efforts on this! Generally is seems and works as expected. I just left some minor comments so that we can make it perfect 🎉 !
It seems that the image should be vertically centered?
Figma
This PR
Also, I am not sure if I would prefer the image being centered or full width (since it is an SVG) in mobile
| * availabile. | ||
| */ | ||
| const extensionAvailableOnPlan = getJetpackExtensionAvailability( 'social-previews' ); | ||
| // TODO: remove before submitting PR for a review. |
Contributor
There was a problem hiding this comment.
It seems the false here should be removed (after testing & before merging)?
| margin-bottom: 2em; | ||
| padding-left: 1em; | ||
|
|
||
| li { |
Contributor
There was a problem hiding this comment.
I would suggest adding
line-height: 20px;
font-size: 14px;in order to match the design
| } | ||
|
|
||
| .jetpack-social-previews__upgrade-heading { | ||
| font-size: 1.9em; |
Contributor
There was a problem hiding this comment.
Just for me learning up... How do you manage effortlessly using em when the design has px ❓
cpapazoglou
reviewed
Aug 7, 2020
Contributor
Author
|
Truly fullwidth image started pushing the text content much lower, I’ve decided to put a max-width on it so the text stays reasonably above the fold. |
obenland
added
[Status] Needs Team Review
marekhrabe
force-pushed
the
add/social-preview-modal-upgrade-nudge
branch
from
18a129a to
8ebc9b2
Compare
marekhrabe
added a commit
that referenced
this pull request
Aug 11, 2020
* add ability for extensions to load images from the jetpack dir * add temporary override for availability check * add first iteration of the upgrade nudge * Update styles * fix typo Co-authored-by: Michael P. Pfeiffer <[email protected]>
marekhrabe
added a commit
that referenced
this pull request
Aug 12, 2020
* update social-previews dependency * add basic modal functionality * add prop overrides for individual previews * connect modal to post data * rewrite upgrade nudge placeholder * remove unused select * upgrade nudge compat * Update extensions/blocks/social-previews/modal.js Co-authored-by: Damián Suárez <[email protected]> * [not verified] extracted the upgrade component to avoid future conflicts * extracted featured image url logic * use optional chaining * Update/social preview modal styles (#16745) * Social Previews: update modal styles * Social Previews: add icons to modal * Social Previews: make icon gray * Social Previews: updates styles for mobile * Social Previews: refactor modal to inject the icon Co-authored-by: cpap <[email protected]> * Use Gutenberg breakpoints * Remove color-studio dependency in favor of Gutenberg colors * Remove atoms colors dependency in favor of Gutenberg colors * Social Previews: Upgrade Nudge in Modal (#16744) * add ability for extensions to load images from the jetpack dir * add temporary override for availability check * add first iteration of the upgrade nudge * Update styles * fix typo Co-authored-by: Michael P. Pfeiffer <[email protected]> * change approach for including image * Restructure styles for improved maintainability * Fix upgrade nudge modal padding * removed debug code * Adjust font sizes in nudge modal * Change TabPanel orientation to vertical for correct arrow key navigation Co-authored-by: Damián Suárez <[email protected]> Co-authored-by: Harris Papazolgou <[email protected]> Co-authored-by: cpap <[email protected]> Co-authored-by: Michael P. Pfeiffer <[email protected]>
pereirinha
pushed a commit
that referenced
this pull request
Sep 10, 2020
* update social-previews dependency * add basic modal functionality * add prop overrides for individual previews * connect modal to post data * rewrite upgrade nudge placeholder * remove unused select * upgrade nudge compat * Update extensions/blocks/social-previews/modal.js Co-authored-by: Damián Suárez <[email protected]> * [not verified] extracted the upgrade component to avoid future conflicts * extracted featured image url logic * use optional chaining * Update/social preview modal styles (#16745) * Social Previews: update modal styles * Social Previews: add icons to modal * Social Previews: make icon gray * Social Previews: updates styles for mobile * Social Previews: refactor modal to inject the icon Co-authored-by: cpap <[email protected]> * Use Gutenberg breakpoints * Remove color-studio dependency in favor of Gutenberg colors * Remove atoms colors dependency in favor of Gutenberg colors * Social Previews: Upgrade Nudge in Modal (#16744) * add ability for extensions to load images from the jetpack dir * add temporary override for availability check * add first iteration of the upgrade nudge * Update styles * fix typo Co-authored-by: Michael P. Pfeiffer <[email protected]> * change approach for including image * Restructure styles for improved maintainability * Fix upgrade nudge modal padding * removed debug code * Adjust font sizes in nudge modal * Change TabPanel orientation to vertical for correct arrow key navigation Co-authored-by: Damián Suárez <[email protected]> Co-authored-by: Harris Papazolgou <[email protected]> Co-authored-by: cpap <[email protected]> Co-authored-by: Michael P. Pfeiffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16729
Changes proposed in this Pull Request:
Jetpack product discussion
—
Does this pull request change what data or activity we track or use?
no
Testing instructions:
Proposed changelog entry for your changes:
none