Skip to content

Form Block: avoid breaking string into 2 because of link #16661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jeherve wants to merge 1 commit into from
Closed

Form Block: avoid breaking string into 2 because of link #16661

jeherve wants to merge 1 commit into from

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Jul 31, 2020 •
edited
Loading

Follow-up from #16519

Changes proposed in this Pull Request:

  • This should make the sentence easier to translate for translators, as they know what the complete sentence is and how it ends.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

  • Add a new Form block to a post.
  • Check the CRM integration question in the block sidebar.

Proposed changelog entry for your changes:

  • N/A

@jeherve
Form Block: avoid breaking string into 2 because of link
66b4089 
This should make the sentence easier to translate for translators.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form [Status] Needs Review This PR is ready for review. [Focus] i18n Internationalization / i18n, adaptation to different languages labels Jul 31, 2020
@jeherve jeherve added this to the 8.9 milestone Jul 31, 2020
@jeherve jeherve requested a review from kbrown9 July 31, 2020 10:02
@jeherve jeherve self-assigned this Jul 31, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Jul 31, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16661

Scheduled Jetpack release: August 4, 2020.
Scheduled code freeze: July 28, 2020

Generated by 🚫 dangerJS against 66b4089

This was referenced Jul 31, 2020
Merged
Merged
@jeherve
Copy link
Member Author

jeherve commented Jul 31, 2020

Fixed in #16667

@jeherve jeherve closed this Jul 31, 2020
@jeherve jeherve deleted the update/jetpack-crm-link-string branch July 31, 2020 15:25
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label Sep 29, 2021
@jeherve jeherve added the [Plugin] CRM Issues about the Jetpack CRM plugin label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbrown9 kbrown9 Awaiting requested review from kbrown9

Assignees

@jeherve jeherve

Labels

[Feature] Contact Form [Focus] i18n Internationalization / i18n, adaptation to different languages [Plugin] CRM Issues about the Jetpack CRM plugin [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

8.9

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @kraftbj @matticbot