Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Aug 12, 2020

Changes proposed in this Pull Request:

This should facilitate the installation and the configuration of the plugin.
The installation tools in there are to be used in tandem with a JITM, introduced in D48025-code.

Jetpack product discussion

  • Internal references:
    • pbtFPC-GX-p2
    • pbtFPC-HO-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Apply D48025-code on your WordPress.com sandbox.
  • Start on a Jetpack site with this branch checked out.
  • The Jetpack site should point to your WordPress.com sandbox, with the JETPACK__SANDBOX_DOMAIN constant.
  • I would recommend disabling the cache for JITM messages, with add_filter( 'jetpack_just_in_time_msg_cache', '__return_false' );
  • The site must be connected to WordPress.com, and the Contact Form module must be active.
  • The Creative Mail plugin should not be active on your site.
    • You can test this diff with both the plugin installed but not active, or not installed at all.
  • Go to the Feedback menu in your dashboard.
  • Try clicking the CTA in the banner that appears.
  • Upon plugin activation, run wp option get CE4WP_REFERRED_BY
  • You should see the following data being returned:
array (
  'plugin' => 'jetpack',
  'version' => '8.9-alpha',
  'time' => 1597304061,
  'source' => 'jitm',
)

Proposed changelog entry for your changes:

  • Compatibility: add new Creative Mail compatiblity file.

This should facilitate the installation and the configuration of the plugin.

The installation tools in there are to be used in tandem with a JITM.
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Status] Needs Review This PR is ready for review. [Pri] Normal [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. labels Aug 12, 2020
@jeherve jeherve added this to the 8.9 milestone Aug 12, 2020
@jeherve jeherve self-assigned this Aug 12, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D48026-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Aug 12, 2020
@jeherve jeherve force-pushed the add/creative-mail-compat-jitm branch from 8041372 to 4ca8ddf Compare August 12, 2020 17:14
@jetpackbot
Copy link
Collaborator

jetpackbot commented Aug 12, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16818

Scheduled Jetpack release: September 1, 2020.
Scheduled code freeze: August 25, 2020

Generated by 🚫 dangerJS against 153c5b8

@sergeymitr sergeymitr self-requested a review August 14, 2020 19:43
Copy link
Contributor

@sergeymitr sergeymitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as a charm 🚢

@sergeymitr sergeymitr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Aug 14, 2020
@jeherve jeherve merged commit 97c3dd6 into master Aug 17, 2020
@jeherve jeherve deleted the add/creative-mail-compat-jitm branch August 17, 2020 10:12
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Aug 17, 2020
@jeherve
Copy link
Member Author

jeherve commented Aug 17, 2020

r212216-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Pri] Normal [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants