Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Aug 13, 2020

Built on top of #16818, do not merge for now. We can change the base branch once the other PR has been merged.

Changes proposed in this Pull Request:

  • When installing the plugin via Jetpack, automatically configure some plugin options.

Note

I was originally hoping to use the activated_plugin action provided by Core, but it then wouldn't be possible to pass a source that we can use in the option. I consequently ended up creating a new hook (I added the docblock in #16821), that we can also use when activating the plugin via the plugins endpoints introduced in #16713.

Jetpack product discussion

  • Internal reference: pbtFPC-H5-p2

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

array (
  'plugin' => 'jetpack',
  'version' => '8.9-alpha',
  'time' => 1597304061,
  'source' => 'jitm',
)

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Status] Needs Review This PR is ready for review. [Pri] Normal DO NOT MERGE don't merge it! labels Aug 13, 2020
@jeherve jeherve added this to the 8.9 milestone Aug 13, 2020
@jeherve jeherve self-assigned this Aug 13, 2020
@jeherve jeherve force-pushed the add/creative-mail-compat-configuration branch from e25912d to 848e77b Compare August 13, 2020 07:54
@jeherve jeherve force-pushed the add/creative-mail-compat-configuration branch from 848e77b to 122152f Compare August 13, 2020 08:05
@jeherve jeherve force-pushed the add/creative-mail-compat-configuration branch from 122152f to 7af85b0 Compare August 13, 2020 10:14
@jeherve jeherve merged commit 153c5b8 into add/creative-mail-compat-jitm Aug 14, 2020
@jeherve jeherve deleted the add/creative-mail-compat-configuration branch August 14, 2020 12:08
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants