Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Aug 13, 2020

Changes proposed in this Pull Request:

Do not merge. This is meant as a tool to test #16824.

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to Posts > Add New
  • Add a form block
  • In the block sidebar, open the Jetpack CRM panel. It's not pretty but that's just for the test.
  • It should be able to detect the list of plugins on your site (check the call to /v4/plugins in your network tools).
  • Try to click on the button to install and activate the plugin; it should work. Check the call to /v4/plugins in your network tools; it's going to take a while and there is no feedback in the UI about the successful install.
  • Reload the page; the CRM panel should now have a different message as the plugin is now active.
  • Deactivate the plugin (but don't delete). Go back to the post editor, and you should now be able to activate the plugin from the button in the block sidebar (check the call to /v4/plugins in your network tools).

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack DO NOT MERGE don't merge it! labels Aug 13, 2020
@jeherve jeherve self-assigned this Aug 13, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D48091-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

Base automatically changed from add/plugin-management-tools-gutenberg to add/plugin-management-endpoints August 14, 2020 12:07
@jeherve jeherve force-pushed the add/plugin-management-jetpack-crm branch from d38c88a to da180b5 Compare August 14, 2020 12:15
Base automatically changed from add/plugin-management-endpoints to master August 17, 2020 12:06
@jeherve
Copy link
Member Author

jeherve commented Aug 17, 2020

Closing this now that the matching PR has been merged.

@jeherve jeherve closed this Aug 17, 2020
@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Aug 17, 2020
@jeherve jeherve added the [Plugin] CRM Issues about the Jetpack CRM plugin label Apr 12, 2023
@kraftbj kraftbj deleted the add/plugin-management-jetpack-crm branch April 17, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE don't merge it! [Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] CRM Issues about the Jetpack CRM plugin [Status] Needs Package Release This PR made changes to a package. Let's update that package now. Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants