-
Notifications
You must be signed in to change notification settings - Fork 846
Enable upgrade banner for WoA sites #19762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Gutenberg extensions
- Use Core's block editor
- Use latest stable Gutenberg plugin
Blocks
- Tiled Gallery
- Business Hours
- Calendly
- Form
- Contact Info
- Eventbrite
- Google calendar
- Mailchimp
- Map
- OpenTable
- Podcast player
- Star rating
- Recurring Payments
- Repeat Visitor
- Revue
- Simple Payments
- Slideshow
Extensions
- Publicize
- Likes
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @retrofox!
While it works as expected for Simple Sites and Atomic with a plan, I cannot test it with Atomic without plan cause in that case Jetpack Beta is deactivated...
Is there a workaround for this?
Using my local Jetpack with wpcomsh was enough! In that case:
- Simple Sites 🎉
- Atomic with a plan 🎉
- Atomic without a plan 🎉
projects/plugins/jetpack/changelog/update-simple-and-atomic-plan-parity
Outdated
Show resolved
Hide resolved
cpapazoglou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and works great!
I just left some minors.
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you'll need to fix the linting issues and update your PR with the latest version of master before we can merge.
…an-parity Co-authored-by: Harris Papazolgou <[email protected]>
Co-authored-by: Paul Bunkham <[email protected]>
Co-authored-by: Paul Bunkham <[email protected]>
67f0b5a to
732d5c6
Compare
samiff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
I've tested this with:
All work as expected. |
|
Great news! One last step: head over to your WordPress.com diff, D61083-code, and commit it. Thank you! |
|
r225990-wpcom |
Fixes #19498
Changes proposed in this Pull Request:
This PR adds the features availability logic according to the site plan for Atomic sites.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Simple sites
freeplan and paid blocks, you should see the upgrade banner:Atomic sites
update/simple-and-atomic-plan-paritybranchTheAlmost the same behavior that Simple sites: show upgrade banner for paid blocks when the site has afreeplan, with the difference that the button link should lead to the plans page, instead of the checkout one.Jetpack sites
No upgrade banners at all. Some (paid for Simple and Atomic sites) blocks are available for Jetpack sites, such as
Calendly,Payments,Video, etc. Other won't be, for instanceDonationsblock.