Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 14, 2022

Changes proposed in this Pull Request:

We enabled this back in October 2021 in the hope that WordPress Core
would quickly make progress on their own PHP 8.1 compatibility project.
That has not at all been born out, four months later they still need to
update their copy-pasted version of their own requests library and
still need to fix another random deprecation warning despite a short
PR
existing.

GitHub's handling for expected-failing tests is lacking, so having a
test, even one flagged experimental, failing long term causes some other
issues. At this point, let's just disable the test until one or the
other makes some progress.

Jetpack product discussion

p1644842786633359-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • The "PHP tests: PHP 8.1 WP master" job should no longer run.

We enabled this back in October 2021 in the hope that WordPress Core
would quickly make progress on their own PHP 8.1 compatibility project.
That has not at all been born out, four months later they still need to
update their copy-pasted version of their own requests library and
still need to fix another random deprecation warning despite [a short
PR][1] existing.

GitHub's handling for expected-failing tests [is lacking][2], so having a
test, even one flagged experimental, failing long term causes some other
issues. At this point, let's just disable the test until one or the
other makes some progress.

[1]: WordPress/wordpress-develop#1801
[2]: https://github.com/actions/toolkit/issues/399
@anomiex anomiex self-assigned this Feb 14, 2022
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 14, 2022
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@anomiex anomiex enabled auto-merge (squash) February 14, 2022 14:23
@anomiex anomiex merged commit 679b924 into master Feb 14, 2022
@anomiex anomiex deleted the fix/disable-php-8.1-tests branch February 14, 2022 14:33
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 14, 2022
@anomiex
Copy link
Contributor Author

anomiex commented Feb 14, 2022

For the record: p9dueE-4qH-p2

anomiex added a commit that referenced this pull request Dec 16, 2022
This will reenable tests against PHP 8.1, which had been disabled in #22850.

When running trunk tests, trick WorDBless into using a nightly by updating
the roots/wordpress package it depends on.

Set REQUESTS_SILENCE_PSR0_DEPRECATIONS in packages/connection bootstrap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants