Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 14, 2022

Changes proposed in this Pull Request:

This will reenable tests against PHP 8.1, which had been disabled in #22850.

Jetpack product discussion

p1644842786633359-slack-CBG1CP4EN
p9dueE-4qH-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Make sure that the PHP 8.1 tests are either passing or are failing because of errors in our own code rather than WordPress Core.
  • Or make sure GitHub Actions will now show the failing test with some sort of "expected" status, as described in actions/toolkit#399, rather than various status indicators showing "failing".

@anomiex anomiex self-assigned this Feb 14, 2022
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Feb 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/reenable-php-8.1-tests to get started. More details: p9dueE-5Nn-p2

@anomiex
Copy link
Contributor Author

anomiex commented Dec 16, 2022

PHP 8.1 tests pass now!

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 16, 2022
@kraftbj kraftbj enabled auto-merge (squash) December 16, 2022 20:01
@anomiex anomiex disabled auto-merge December 16, 2022 20:02
@anomiex anomiex enabled auto-merge (squash) December 16, 2022 20:03
@anomiex anomiex merged commit 4608264 into trunk Dec 16, 2022
@anomiex anomiex deleted the update/reenable-php-8.1-tests branch December 16, 2022 20:03
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Package] Connection [Pri] Normal [Status] Needs Test Review [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants