mu-wpcom: add coming-soon code from ETK

[samiff]

Changes proposed in this Pull Request:

Migration of coming-soon feature from the ETK plugin.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

PT: p9dueE-6jY-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Review the code. We aren't loading jetpack-mu-wpcom on sites just yet.
• Merged D94672-code which should allow usage of bin/jetpack-downloader test jetpack-mu-wpcom add/coming-soon-to-wpcom-mu
• Calypso check added in ETK: add check before loading coming-soon feature wp-calypso#71012
  • Merged and deployed to simple/Atomic D94911-code

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ⚠️ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack Mu wpcom plugin:

• Next scheduled release: January 3, 2023.
• Scheduled code freeze: December 26, 2022.

[samiff]

@anomiex I imagine for migrated PHP tests we'd want to use wordbless? Here is the ETK bootstrap.php for reference. I've given that a shot in e10a182f2511bbda0a4bee4cb310b598bd9f19c3 but thought I'd check in before continuing further.

Edit: also merged D94672-code which seemed to work ok.

[anomiex]

Using WorDBless would be good if it's possible, it makes it easier for people to run tests locally. OTOH, in CI all plugins are set up inside a copy of WordPress, so if that's what it needs it can use it.

[samiff]

@anomiex

Just wanted to get a gut-check in regards to deploy:

• In this plugin we're checking has_action( 'plugins_loaded', 'A8C\FSE\load_coming_soon' ) before loading coming-soon, and my plan was to add a similar check on the Calypso side checking for Jetpack\Mu_Wpcom\load_coming_soon before loading the feature.
  • Checks on both side since there isn't a guarantee of plugin load order from what I read, unless I'm missing a different strategy?
• If the above makes sense, that change in ETK plugin would get deployed to simple and Atomic.
• Then this plugin could safely be activated on simple and Atomic.
• Finally, remove the checks and coming-soon code from ETK.

Does that sound about right to you?

[anomiex]

Just wanted to get a gut-check in regards to deploy

That sounds like a good plan.

I believe that the loading order will be consistent (because plugin load order is alphabetical AFAIK), but what that order will actually be I don't know. And might differ between Simple and Atomic.

[anomiex]

I'm kind of confused on why the $blog_id is needed here to begin with if this ETK code is always running via a plugin.

Running via a plugin doesn't matter. The blog ID is needed when it's running on a multi-site, and probably on Simple too.

For the second one, that test is failing because wordbless doesn't support add_blog_option as used by add_option_to_new_site().

More specifically, the relevant file (ABSPATH . '/wp-includes/ms-blogs.php') isn't loaded by default because it's not a multisite site. I don't know whether WorDBless supports being a multisite or not, but it does seem to work if you manually require that file. Or you could just mock the relevant function to call add_option().

[samiff]

The blog ID is needed when it's running on a multi-site, and probably on Simple too.

Thanks, I didn't notice what this was doing by hooking into wpmu_new_blog but understand now.

Or you could just mock the relevant function to call add_option().

As far as mocking goes, how does bd13825 look?

[samiff]

Error: main: Task checkDescription failed with error: TypeError: Cannot read properties of undefined (reading 'automattic/jetpack-changelogger')

Hmm thought it was something to do with the empty changelog, but that didn't seem to help: c50d89e Any idea on what the snag is, or how I can get more helpful error output (e.g., line number)?

[anomiex]

Hmm thought it was something to do with the empty changelog, but that didn't seem to help: c50d89e Any idea on what the snag is, or how I can get more helpful error output (e.g., line number)?

I don't know about getting more helpful output, but I suspect it's because of this removal and the code at

jetpack/projects/github-actions/repo-gardening/src/utils/get-affected-changelogger-projects.js

Line 18 in c20c485

json.require[ 'automattic/jetpack-changelogger' ] ||

For this PR, try adding this back. In a separate PR, we should change that code to use ?. for the accesses so it doesn't error out for something like this.

[samiff]

In a separate PR, we should change that code to use ?. for the access

Nice catch! I'll be sure to follow up on that one 👍

[anomiex]

I haven't tested it, but the code looks good to me.