Skip to content

Conversation

@samiff
Copy link
Contributor

@samiff samiff commented Jan 20, 2023

Proposed changes:

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Internal PT: p9dueE-6jY-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

The jetpack-mu-wpcom package or plugin is not used in production anywhere just yet, so merging this should be safe and follow-up PRs can be used to address any issues that popup when implementing on wpcom/WoA. The bulk of the code in this PR is migration from #27815

I did do some quick testing on simple wpcom:

  • bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/migrate-coming-soon-to-package
  • Will need to uncomment the require to mu-wpcom-plugin.php in 0-wpcom-jetpack-loader.php.
  • If not merged/deployed yet, will want to patch with changes in ETK: update loading coming-soon check wp-calypso#72901
  • Can then add some error logging to prod/full-site-editing-plugin.php & class-jetpack-mu-wpcom.php vendor package file to verify which codepath is being loaded.
  • Enable the Coming Soon feature and test it out. Check PHP error log, there should be no redeclaration or other errors.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Mu Wpcom plugin plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 27, 2023.

Base automatically changed from add/jetpack-mu-wpcom-plugin to trunk January 27, 2023 21:25
We are using plugins/mu-wpcom-plugin instead.
@samiff samiff marked this pull request as ready for review February 2, 2023 19:42
@samiff samiff requested a review from anomiex February 2, 2023 19:42
@samiff samiff added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Feb 2, 2023
@samiff samiff enabled auto-merge (squash) February 2, 2023 19:53
@samiff samiff requested a review from zinigor February 3, 2023 19:34
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is basically the same as what was removed in #28445, let's do it.

@samiff samiff merged commit c9af508 into trunk Feb 6, 2023
@samiff samiff deleted the update/migrate-coming-soon-to-package branch February 6, 2023 19:17
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Feb 6, 2023
@sdixon194
Copy link
Contributor

Was just about to approve as well - also functionally tested on wpcom by requiring the new plugin and confirmed it loads and works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants