-
Notifications
You must be signed in to change notification settings - Fork 846
jetpack-mu-wpcom: migrate coming-soon to package #28498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Copy/paste of the code, will refactor in following commits.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin plugin:
|
We are using plugins/mu-wpcom-plugin instead.
anomiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is basically the same as what was removed in #28445, let's do it.
|
Was just about to approve as well - also functionally tested on wpcom by requiring the new plugin and confirmed it loads and works fine. |
Proposed changes:
jetpack-mu-wpcompackage, that was previously added to the plugin version in mu-wpcom: add coming-soon code from ETK #27815Other information:
Jetpack product discussion
Internal PT: p9dueE-6jY-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
The
jetpack-mu-wpcompackage or plugin is not used in production anywhere just yet, so merging this should be safe and follow-up PRs can be used to address any issues that popup when implementing on wpcom/WoA. The bulk of the code in this PR is migration from #27815I did do some quick testing on simple wpcom:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/migrate-coming-soon-to-packagemu-wpcom-plugin.phpin0-wpcom-jetpack-loader.php.prod/full-site-editing-plugin.php&class-jetpack-mu-wpcom.phpvendor package file to verify which codepath is being loaded.