Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Dec 14, 2022

Changes proposed in this Pull Request:

We can't enable these since WP Core doesn't even support 8.1 yet, but we may as well include it alongside the commented-out 8.1 tests.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

We can't enable these since WP Core doesn't even support 8.1 yet, but we
may as well include it alongside the commented-out 8.1 tests.
@anomiex anomiex self-assigned this Dec 14, 2022
@anomiex anomiex enabled auto-merge (squash) December 14, 2022 17:47
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Dec 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 14, 2022
@anomiex anomiex merged commit 4895a29 into trunk Dec 14, 2022
@anomiex anomiex deleted the add/commented-out-php-8.2-tests branch December 14, 2022 20:16
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants