Skip to content

Conversation

@anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 20, 2023

Proposed changes:

Now that we have it working, this undoes the changes from #28467 and #28502. The Post-Build workflow is now responsible for the plugin upgrades check, and the Slack notification has been updated to correctly handle being triggered by the Post-Build workflow.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Merge then see if stuff works

Now that we have it working, this undoes the changes from #28467
and #28502. The Post-Build workflow is now responsible for the plugin
upgrades check, and the Slack notification has been updated to correctly
handle being triggered by the Post-Build workflow.
@anomiex anomiex self-assigned this Jan 20, 2023
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jan 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run bin/jetpack-downloader test jetpack update/re-enable-post-build-stuff to get started. More details: p9dueE-5Nn-p2

@anomiex anomiex mentioned this pull request Jan 20, 2023
3 tasks
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 24, 2023
@anomiex anomiex merged commit c4d9d6e into trunk Jan 26, 2023
@anomiex anomiex deleted the update/re-enable-post-build-stuff branch January 26, 2023 16:42
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants