Skip to content

Conversation

@samiff
Copy link
Contributor

@samiff samiff commented Jan 19, 2023

Proposed changes:

This plugin will:

  • Consume packages/jetpack-mu-wpcom
  • Allow us to store the built plugin artifact (used in other tooling and release process) which contains the package code.
  • Provide an additional testing vector for jetpack-mu-wpcom via the Jetpack Beta Tester plugin

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Internal: p1674159922879619-slack-C01U2KGS2PQ

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Proofread and make sure it all builds.

@samiff samiff added [Status] Needs Review This PR is ready for review. [Package] Jetpack mu wpcom WordPress.com Features labels Jan 19, 2023
@samiff samiff requested a review from anomiex January 19, 2023 22:55
@samiff samiff self-assigned this Jan 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack Mu wpcom plugin plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

Mu Wpcom plugin plugin:

  • Next scheduled release: February 7, 2023.
  • Scheduled code freeze: January 30, 2023.

@samiff
Copy link
Contributor Author

samiff commented Jan 19, 2023

@anomiex Should this have a mirror repo? Also, can we just modify the current "jetpack-mu-wpcom" entry in the plugins.json beta manifest?

@anomiex
Copy link
Contributor

anomiex commented Jan 20, 2023

Should this have a mirror repo?

I think the tooling will require that. Without a mirror repo it won't make an entry in the "jetpack-build" artifact, so the rest of the stuff won't have anything to run on.

Also, can we just modify the current "jetpack-mu-wpcom" entry in the plugins.json beta manifest?

Yes, that should work.

@samiff
Copy link
Contributor Author

samiff commented Jan 20, 2023

@anomiex Could you help me understand the failing Test plugin upgrades please. Previously the built artifact was lacking a vendor directory, so I tried updating the production-include. Though now it's failing for a different reason I can't quite make sense of:

Fetching jetpack-mu-wpcom-plugin-trunk.zip...
  jq: error: Could not open file monorepo/projects/plugins/jetpack-mu-wpcom-plugin/composer.json: No such file or directory

@anomiex
Copy link
Contributor

anomiex commented Jan 20, 2023

Ah, the Post-Build version is trying to read the composer.json from trunk rather than this branch, and it doesn't exist in trunk... Let's see if 51a1671 fixes it.

@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jan 20, 2023
@anomiex
Copy link
Contributor

anomiex commented Jan 20, 2023

Ick, looks like the changes here basically need #28510. I suppose we could apply a similar change to the copy of the job in build.yml, which will make this and that conflict...

@anomiex
Copy link
Contributor

anomiex commented Jan 22, 2023

Random complaint: Can we name the directory something that doesn't start with "jetpack"? I'm used to typing pro<tab>pl<tab>j<tab> at the monorepo root when accessing files in Jetpack, and when "jetpack-mu-plugin" existed that got in the way. 😀

@samiff samiff added [Status] In Progress and removed [Status] Needs Review This PR is ready for review. labels Jan 24, 2023
@samiff
Copy link
Contributor Author

samiff commented Jan 24, 2023

Can we name the directory something that doesn't start with "jetpack"?

Done!

So it sounds like #28510 needs to merge first. And should I wait to update the beta manifest until after this merges?

@samiff samiff added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Jan 24, 2023
@anomiex
Copy link
Contributor

anomiex commented Jan 26, 2023

I'd probably update the manifest just before merging this just so I could watch for the resulting trunk build being picked up correctly.

@anomiex
Copy link
Contributor

anomiex commented Jan 26, 2023

D'oh, the changes to the workflow need to be done in a separate PR because it runs off of trunk. I'll create that momentarily.

@samiff
Copy link
Contributor Author

samiff commented Jan 27, 2023

@anomiex Looks like the workflow is working now 👍 Anything else on this one? I can update the beta manifest once this is ready to merge.

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it. Note you'll also have to update the jetpack-downloader script, and I think @sdixon194's shiny button script too if that has been merged already.

@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 27, 2023
@samiff samiff merged commit 0ce31f1 into trunk Jan 27, 2023
@samiff samiff deleted the add/jetpack-mu-wpcom-plugin branch January 27, 2023 21:25
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Test Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants