Skip to content

Conversation

@donnchawp
Copy link
Contributor

@donnchawp donnchawp commented Jun 8, 2023

As site owners reply to form responses to contact their customers, they didn't want links to wp-admin in the email. This PR removes the two links in a backwards compatible way, in case any customer has decided to modify the template already.

Proposed changes:

  • Remove the view response and edit links from the form response emails.
  • Leave in the %3$s and %4$s arguments in case any site owner has changed the template already.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pcsBup-yo-p2#comment-497

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Apply PR.
Embed a contact form in a test post.
Fill in the form.
You should receive an email with the form response. It will not link to the feedback admin page, or to the post editor.

Before and after screenshots:
Before
After

@donnchawp donnchawp marked this pull request as ready for review June 8, 2023 13:13
@donnchawp donnchawp requested a review from jeherve June 8, 2023 13:13
@donnchawp donnchawp self-assigned this Jun 8, 2023
@donnchawp donnchawp requested a review from CGastrell June 8, 2023 13:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/remove_links_from_forms_email

to get started. More details: p9dueE-5Nn-p2

@donnchawp donnchawp added [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] In Progress labels Jun 8, 2023
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine for me! :shipit:

@donnchawp donnchawp merged commit 3b86fd0 into trunk Jun 8, 2023
@donnchawp donnchawp deleted the update/remove_links_from_forms_email branch June 8, 2023 16:20
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label Jun 8, 2023
jeherve added a commit that referenced this pull request Jul 10, 2023
Fixes #31774

This applies the changes from #31270 to the old codebase too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants