Skip to content

Conversation

@jeherve
Copy link
Member

@jeherve jeherve commented Jul 10, 2023

Fixes #31774

Proposed changes:

This applies the changes from #31270 to the old codebase too. Since we do not use that codebase by default since #28791, this should not change anything to the current behavior.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

Not much to test here, as I mentioned above. You could try using the jetpack_contact_form_use_package filter to not use the package anymore, then add a form to your site, submit a form, and see the email you receive, to check that this works properly.
Or you can check that CI is happy.

Fixes #31774

This applies the changes from #31270 to the old codebase too.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Contact Form [Status] Needs Review This PR is ready for review. [Pri] Low labels Jul 10, 2023
@jeherve jeherve requested a review from donnchawp July 10, 2023 11:12
@jeherve jeherve self-assigned this Jul 10, 2023
@jeherve jeherve enabled auto-merge (squash) July 10, 2023 11:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/forms-response-template-old-module branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/forms-response-template-old-module
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests labels Jul 10, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: August 1, 2023.
  • Scheduled code freeze: July 25, 2023.

@jeherve jeherve merged commit 08713a2 into trunk Jul 12, 2023
@jeherve jeherve deleted the update/forms-response-template-old-module branch July 12, 2023 12:21
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 12, 2023
@github-actions github-actions bot added this to the jetpack/12.4 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Tests] Includes Tests [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contact Form: remove links to wp-admin from form response email in old codebase as well

3 participants