Forms: remove Dashboard Switch class #45282

CGastrell · 2025-09-23T21:27:57Z

Proposed changes:

This PR removes Dashboard_View_Switch class, which has been in deprecation since moving towards the new dashboard and removal of the legacy menu/listing.

This shouldn't be mixed with current proposal to deprecate Admin class, which carries more legacy and backwards compatibility checks.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None yet, but there will be

Does this pull request change what data or activity we track or use?

No

Testing instructions:

As with any removal, the idea is that nothing has changed and tests pass. Special attention to any of the tasks in charge of Dashboard View Switch, although most of them had been deprecated via conditionals based on flags that are now set to default values that never make it through those conditionals.

Also, moved some of the useful methods on the class to static methods on Dashboard:

get_forms_admin_url
append_tab_to_url
is_jetpack_forms_admin_page

…d new static methods

github-actions · 2025-09-23T21:28:45Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the remove/forms-dashboard-switch-class branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack remove/forms-dashboard-switch-class

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-09-23T21:28:53Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: October 7, 2025
- Code freeze: October 6, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-09-23T21:37:17Z

Code Coverage Summary

Coverage changed in 8 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/class-jetpack-forms.php	4/15 (26.67%)	-6.67%	1 ❤️‍🩹
projects/packages/forms/src/contact-form/class-contact-form-endpoint.php	579/652 (88.80%)	-0.07%	0 💚
projects/packages/forms/src/contact-form/class-contact-form-plugin.php	424/1305 (32.49%)	0.02%	-1 💚
projects/packages/forms/src/util/get-preferred-responses-view.js	0/2 (0.00%)	0.00%	-1 💚
projects/packages/forms/src/blocks/contact-form/class-contact-form-block.php	395/591 (66.84%)	0.34%	-3 💚

Full summary · PHP report · JS report

_{Coverage check overridden by

Coverage tests to be added later
Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR
.}

vianasw · 2025-09-24T10:46:56Z

projects/packages/forms/src/contact-form/class-contact-form.php

 		$footer_mark_as_spam_url = '';
 		if ( $feedback_status !== 'jp-temp-feedback' ) {
-			$dashboard_url           = ( new Dashboard_View_Switch() )->get_forms_admin_url( $status, true ) . '&r=' . $post_id;
+			$dashboard_url           = Forms_Dashboard::get_forms_admin_url( $status ) . '&r=' . $post_id;


Nitpick: $status is a confusing name, $tab would work better.

I'll agree with you semantically, but as the tab also represents the post status, I think it can stay. Besides, it's unrelated to the main goal of this PR.

projects/packages/forms/src/dashboard/class-dashboard.php

vianasw

I've added a few comments that aren't blockers, but there are e2e tests failing that need fixing. I've manually tested it and everything seemed to be working fine.

CGastrell added 5 commits September 23, 2025 18:05

move view switch methods into dashboard static methods

bf1522c

remove migration page and all related consts

5a6a8f8

remove/replace references/calls to Dashboard_View_Switch for Dashboar…

4207901

…d new static methods

assume defaults and not conditional menu rendering

29ad5fb

remove old menu hook

4374902

CGastrell self-assigned this Sep 23, 2025

github-actions bot added [Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Tests] Includes Tests labels Sep 23, 2025

CGastrell requested a review from a team September 23, 2025 21:46

CGastrell added 5 commits September 24, 2025 00:53

declare class usage

3e3f482

changelog

579e96b

remove expected keys after deprecation

41ac9ab

update phan baselines

0b0a59c

instead of deleting the class file, add tests and tag for deprecation

0e9a2ce

CGastrell force-pushed the remove/forms-dashboard-switch-class branch from 9123262 to 0e9a2ce Compare September 24, 2025 04:41

github-actions bot added the Docs label Sep 24, 2025

update phan baseline after deprecation tests

9c62d1c

vianasw reviewed Sep 24, 2025

View reviewed changes

projects/packages/forms/src/dashboard/class-dashboard.php Outdated Show resolved Hide resolved

vianasw requested changes Sep 24, 2025

View reviewed changes

improve append_tab_to_url method

4f5ef23

CGastrell requested a review from vianasw September 24, 2025 12:47

vianasw approved these changes Sep 24, 2025

View reviewed changes

CGastrell merged commit 8d468b3 into trunk Sep 24, 2025
77 of 83 checks passed

CGastrell deleted the remove/forms-dashboard-switch-class branch September 24, 2025 13:45

github-actions bot added this to the jetpack/15.1 milestone Sep 24, 2025

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Sep 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Forms: remove Dashboard Switch class #45282

Forms: remove Dashboard Switch class #45282

Uh oh!

CGastrell commented Sep 23, 2025

Uh oh!

github-actions bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

jp-launch-control bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

vianasw Sep 24, 2025

Uh oh!

CGastrell Sep 24, 2025

Uh oh!

Uh oh!

vianasw left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Forms: remove Dashboard Switch class #45282

Forms: remove Dashboard Switch class #45282

Uh oh!

Conversation

CGastrell commented Sep 23, 2025

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 23, 2025

Uh oh!

jp-launch-control bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

vianasw Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

CGastrell Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vianasw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 23, 2025 •

edited

Loading

jp-launch-control bot commented Sep 23, 2025 •

edited

Loading