Skip to content

Forms: remove Dashboard Switch class #45282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGastrell merged 12 commits into from
Sep 24, 2025
Merged

Forms: remove Dashboard Switch class #45282

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bf1522c
move view switch methods into dashboard static methods
CGastrell Sep 23, 2025
5a6a8f8
remove migration page and all related consts
CGastrell Sep 23, 2025
4207901
remove/replace references/calls to Dashboard_View_Switch for Dashboar…
CGastrell Sep 23, 2025
29ad5fb
assume defaults and not conditional menu rendering
CGastrell Sep 23, 2025
4374902
remove old menu hook
CGastrell Sep 23, 2025
3e3f482
declare class usage
CGastrell Sep 23, 2025
579e96b
changelog
CGastrell Sep 23, 2025
41ac9ab
remove expected keys after deprecation
CGastrell Sep 23, 2025
0b0a59c
update phan baselines
CGastrell Sep 23, 2025
0e9a2ce
instead of deleting the class file, add tests and tag for deprecation
CGastrell Sep 24, 2025
9c62d1c
update phan baseline after deprecation tests
CGastrell Sep 24, 2025
4f5ef23
improve append_tab_to_url method
CGastrell Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assume defaults and not conditional menu rendering
  • Loading branch information
@CGastrell
CGastrell committed Sep 23, 2025
commit 29ad5fb30c6e9a0404fcd6deaa3675f43bf39909
13 changes: 6 additions & 7 deletions projects/packages/forms/src/contact-form/class-contact-form-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,7 @@ public static function gutenblock_render_field_image_select( $atts, $content, $b
public function admin_menu() {
$slug = 'feedback';

if ( is_plugin_active( 'polldaddy/polldaddy.php' ) || ! Jetpack_Forms::is_legacy_menu_item_retired() ) {
if ( is_plugin_active( 'polldaddy/polldaddy.php' ) ) {
add_menu_page(
__( 'Feedback', 'jetpack-forms' ),
__( 'Feedback', 'jetpack-forms' ),
Expand All @@ -1385,12 +1385,11 @@ public function admin_menu() {
$slug
);

if ( Jetpack_Forms::is_legacy_menu_item_retired() ) {
remove_submenu_page(
$slug,
'edit.php?post_type=feedback'
);
}
// remove the first default submenu item
remove_submenu_page(
$slug,
'edit.php?post_type=feedback'
);
}

/**
Expand Down