Skip to content

fix: make getters convert uuid to string when calling toObject() and toJSON() #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: make getters convert uuid to string when calling toObject() and toJSON() #14890

merged 4 commits into from
Sep 17, 2024

Conversation

@vkarpov15
Copy link
Collaborator

@vkarpov15 vkarpov15 commented Sep 16, 2024

Fix #14869

Summary

As #14869 pointed out, calling toObject() on a document with uuids with getters: true ends up with "[object -Obje-ct]--" strings 😢 This PR should fix that

Examples

@vkarpov15 vkarpov15 added this to the 8.6.3 milestone Sep 16, 2024
hasezoey
hasezoey approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor duplicated checks

vkarpov15 and others added 2 commits September 17, 2024 11:18
@vkarpov15 vkarpov15 merged commit 3902283 into master Sep 17, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14869 branch September 17, 2024 15:27
@zntb zntb mentioned this pull request Oct 10, 2024
Merged
@natrogue natrogue mentioned this pull request Oct 10, 2024
Open
@ASHOKECE1999 ASHOKECE1999 mentioned this pull request Oct 10, 2024
Open
@ValeriaTapiaG ValeriaTapiaG mentioned this pull request Oct 12, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 13, 2024
Open
@DulranS DulranS mentioned this pull request Oct 14, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 16, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 20, 2024
Open
@ShivamNimje6 ShivamNimje6 mentioned this pull request Oct 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 22, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 23, 2024
Open
@sharma731 sharma731 mentioned this pull request Oct 23, 2024
Open
@DulranS DulranS mentioned this pull request Oct 23, 2024
Open
@zntb zntb mentioned this pull request Oct 24, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Oct 25, 2024
Open
@ranjith221132 ranjith221132 mentioned this pull request Oct 25, 2024
Open
@k2xl k2xl mentioned this pull request Oct 25, 2024
Closed
@hamzabetbaieb hamzabetbaieb mentioned this pull request Oct 25, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Oct 25, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 25, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 2, 2024
Open
@DulranS DulranS mentioned this pull request Nov 3, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Nov 3, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 3, 2024
Open
@PietroBossolasco PietroBossolasco mentioned this pull request Nov 3, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 4, 2024
Open
@DulranS DulranS mentioned this pull request Nov 4, 2024
Open
@rodrigo3829l rodrigo3829l mentioned this pull request Nov 4, 2024
Open
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 5, 2024
Merged
@saileshbro saileshbro mentioned this pull request Nov 5, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 5, 2024
Merged
@MSK-009 MSK-009 mentioned this pull request Nov 5, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Nov 6, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Nov 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Nov 6, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Closed
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@Anteneh-T-Tessema Anteneh-T-Tessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@DulranS DulranS mentioned this pull request Nov 10, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
@DulranS DulranS mentioned this pull request Nov 11, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasezoey hasezoey hasezoey approved these changes

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

8.6.3

Development

Successfully merging this pull request may close these issues.

3 participants

@vkarpov15 @hasezoey